Add support for MOTIS Endpoints #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1Maxnet1
changed the title
|
One thing I would like to discuss is how the loaded Datasets can be specified. I thought about how to properly specify the timepspans as a tuple of two dates. Is there a preferred date-format? Then I would add the missing specification to the Readme.md |
|
At the moment you cannot specify the time interval per loaded timetable. MOTIS allows you to set a time span and will extract this time span from every loaded timetable. Date format could be an ISO date string (in UTC) or just a unix timestamp (also UTC). I think the ISO date string would improve readability. |
derhuerst
reviewed
Dec 15, 2022
1Maxnet1
changed the title
derhuerst
approved these changes
Dec 19, 2022
vkrause
approved these changes
Dec 19, 2022
|
Thank you very much for adding MOTIS! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces a draft for the required properties for motis clients and how to specify them. I am only aware of one available motis-server (https://europe.motis-project.de/).
This topic has already been discussed here:
Please let me know what you think. Every kind of feedback is appreciated.
CC: @felixguendling