Fixed bug in position refinement parameter parsing #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a general issue. It looks like all subclasses read the parameters again. Subclasses shouldn't need to read the parameter tree. Needs to be a separate issue. Thanks for finding this bug Benedikt! |
|
Removed the second reading of the parameter tree in DM and ML. But this does not fix the issues with the position refinement subtree, which needs to read sepearately. I have moved that part now into the init() of the PositionCorrection engine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that in the current version of the position correction engine, that defaults and user-provided parameters are not updated properly. Position correction only works if all posref parameters are provided in the configuration.
I've made a quick fix for this. @pierrethibault is there are more elegant way of solving this?
I've also included new tests.