Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating defaults in parameter subtree does not work properly #256

Open
daurer opened this issue Apr 24, 2020 · 2 comments · Fixed by #245
Open

updating defaults in parameter subtree does not work properly #256

daurer opened this issue Apr 24, 2020 · 2 comments · Fixed by #245
Labels
bug review

Comments

@daurer
Copy link
Contributor

daurer commented Apr 24, 2020

I realised this problem in the case of the position refinement parameters. Becasuse the entire engine parameter tree is updated on the main level, entries in the sub-tree (the position refinement parameters) are not updated indivudally insteead the entire list of parameters is overwritten at once. This means that if the user does not specify all available options, there will be missing attributes because the defaults are no longer available.
@daurer daurer added the bug label Apr 24, 2020
@daurer daurer linked a pull request Apr 24, 2020 that will close this issue
Fixed bug in position refinement parameter parsing #245
Merged
@daurer
Copy link
Contributor Author

daurer commented Apr 24, 2020

There is a temporary fix for the problem with the position refinement parameters (see #245) but I believe there is an underlying issue here, so this should probably be fixed in a better way. @bjoernenders @pierrethibault

daurer added a commit that referenced this issue Apr 24, 2020
@daurer
Added reference to open issue #256
808983d
daurer added a commit that referenced this issue Apr 24, 2020
@daurer
Fixed bug in position refinement parameter parsing (#245)
869e8d1 
* Fixed typos

* Added tests for position correction

* Fixed bug in parsing posref parameters

* Removed unnecessary import

* Move parameter update into init() and remove unnecessary update in DM

* Remove unnecessary param update in ML

* Added reference to open issue #256
@daurer daurer reopened this Apr 24, 2020
@bjoernenders
Copy link
Contributor

This bug needs to be reviewed if it still exists. I put it as a child issue of the parameter tree review. #449

@bjoernenders bjoernenders mentioned this issue Jan 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed bug in position refinement parameter parsing ptycho/ptypy
2 participants
@daurer @bjoernenders