Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): add support for uploaded index when signing using notation #1882

Merged

Conversation

Andreea-Lupu
Copy link
Contributor

ci(notation): update to latest notation version

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

test/blackbox/annotations.bats Show resolved Hide resolved
@Andreea-Lupu Andreea-Lupu force-pushed the fix_push_notation_signatures_meta branch from e714b34 to 9cd925c Compare October 10, 2023 23:08
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1882 (26e6058) into main (458d40f) will increase coverage by 0.03%.
The diff coverage is 94.93%.

@@            Coverage Diff             @@
##             main    #1882      +/-   ##
==========================================
+ Coverage   91.95%   91.99%   +0.03%     
==========================================
  Files         153      154       +1     
  Lines       26440    26584     +144     
==========================================
+ Hits        24314    24456     +142     
- Misses       1570     1572       +2     
  Partials      556      556              
Files Coverage Δ
pkg/common/common.go 95.23% <100.00%> (+0.32%) ⬆️
pkg/extensions/sync/references/cosign.go 94.48% <100.00%> (-0.08%) ⬇️
pkg/extensions/sync/references/oci.go 89.82% <100.00%> (+1.65%) ⬆️
pkg/extensions/sync/references/references.go 97.10% <100.00%> (+0.30%) ⬆️
pkg/extensions/sync/service.go 95.59% <100.00%> (+0.01%) ⬆️
pkg/meta/hooks.go 100.00% <100.00%> (ø)
pkg/meta/parse.go 98.91% <100.00%> (+0.01%) ⬆️
pkg/test/signature/notation.go 90.57% <100.00%> (+0.08%) ⬆️
pkg/extensions/sync/references/referrers_tag.go 93.10% <93.10%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Andreea-Lupu Andreea-Lupu force-pushed the fix_push_notation_signatures_meta branch from 9cd925c to 0a2b4f5 Compare October 11, 2023 11:41
andaaron
andaaron previously approved these changes Oct 11, 2023
andaaron
andaaron previously approved these changes Oct 11, 2023
ci(notation): update to latest notation version
fix(sync): add layers info when syncing signatures

Signed-off-by: Andreea-Lupu <[email protected]>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit fc2380b into project-zot:main Oct 13, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants