Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Support ingesting indexes tagged with the referrers tag schema #1896

Closed
andaaron opened this issue Oct 6, 2023 · 1 comment
Closed
Assignees
Labels
feature New feature or request
Milestone

Comments

@andaaron
Copy link
Contributor

andaaron commented Oct 6, 2023

Is your feature request related to a problem? Please describe.

In case a server does not use the referrers API, the spec describes an equivalent workflow managed from client side:
https://github.com/opencontainers/distribution-spec/blob/main/spec.md#unavailable-referrers-api

Basically the client will manage a tag containing the subject hash in the name, which points to an index which contains the data which would have been returned by the referrers API.

zot currently supports the referrers API, but:

  • there are clients who may elect not to use it (disabled by default in latest notation version and release v1.0.0)
  • there are artifacts sync-ed from servers which do not support it

In these cases zot receives these already existing indexes tagged using the https://github.com/opencontainers/distribution-spec/blob/main/spec.md#referrers-tag-schema

There are some issues with current implementation:

  • the logic writing this data in MetaDB for notation signature is bugged, resulting in MetaDB erroring when reading this index, which results in GlobalSearch returning errors
  • there are issues with sync-ing this index, probably the same as for notation, but they need to be investigated

Describe the solution you'd like

The notation signature should correctly be updated in MetaDB when pushing a Notation signature with the referers schema disabled client-side.
The notation signatures should correctly be synced and updated in MetaDB from a server already having an index.
We should sync the index tagged with the referrers schema as well.

Describe alternatives you've considered

No response

Additional context

There is currently a PR which is intended to fix these issues (at a minimum for notation side): #1882

@andaaron andaaron added the feature New feature or request label Oct 6, 2023
@andaaron andaaron changed the title [Feat]: Support the [Feat]: Support ingesting indexes tagged with the referrers tag schema Oct 6, 2023
@andaaron andaaron added this to the v2.0.0 milestone Oct 6, 2023
@andaaron
Copy link
Contributor Author

Done in #1882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants