-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update user permissions when room power levels change, or when they accept an invitation to a room #305
Conversation
Screencast.from.2024-12-27.19-56-49.webm |
looks like things still don't work? i can't quite tell what this screen recording is trying to show.... it looks like you join a room but then it still shows that you don't have permissions to send a message? it also looks like your changes broke the latest event code, since many of the rooms say |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on your screen recording, i think this PR accidentally breaks the latest_event calculation code.
Instead of this new approach where you separate out avatar handling from "can send message" handling, please move it all into a single update_latest_event()
function (like i had before), which will ensure that all of the various possible relevant event kinds are handled upon every change to the latest event (which can occur in multiple places). I think the following 5 things are of interest to us:
- room name
- room avatar
- room power levels
- membership change
- latest event text preview
It works. I apologize for not clarifying the screenshot. I have already used account |
oh i see, that makes more sense then. It appeared to be the opposite. Thanks for clarifying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting closer, but you missed some of what I said here:
Instead of this new approach where you separate out avatar handling from "can send message" handling, please move it all into a single
update_latest_event()
function (like i had before), which will ensure that all of the various possible relevant event kinds are handled upon every change to the latest event (which can occur in multiple places). I think the following 5 things are of interest to us:
- room name
- room avatar
- room power levels
- membership change
- latest event text preview
Yeah. now they are in one function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! Thanks for your great work here!
Fixes #302