Cleanup latest event handling; check room power levels accurately #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When inspecting content from a new latest event that changed room power levels, we now look for not just an invitation being accepted but also for a general room Join action. * When checking a user's power level to see if they can send a message, we now check against the current power levels required to send a message, not the room's default level. We only use the default power level as a backup.
kevinaboos
changed the title
|
@aaravlu after merging in your latest PR #305, I noticed some minor issues with it. I've attempted to address them here in this PR and have requested your review. Can you kindly test it out with all of the previous use cases you tested PR#305 with? )(just to make sure that I didn't break anything) Thanks! |
|
Yes, exactly right. There are two case but I only handled User-initiated room joining And there are three message types while I only handled the org.matrix.msc1767.message |
aaravlu
requested changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some general cleanup & improvements that are follow-ups to PR #305.