Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use konflux-jbs-pnc-tenant/konflux-tooling image #8

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Switch to use konflux-jbs-pnc-tenant/konflux-tooling image #8

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8317a45
Switch to use konflux-jbs-pnc-tenant/konflux-tooling image
rnc Dec 19, 2024
9f410c7
Rename konflux-processor to pnc-konflux-tooling
rnc Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/resources/application.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
konflux-build-driver:
quay-repo: "quay.io/redhat-user-workloads-stage/pnc-devel-tenant/pnc-konflux"
konflux-processor: "quay.io/redhat-user-workloads/konflux-jbs-pnc-tenant/jvm-build-service/build-request-processor:latest"
konflux-processor: "quay.io/redhat-user-workloads/konflux-jbs-pnc-tenant/konflux-tooling:latest"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matejonnet I wonder if we should rename this configuration option to e.g. pnc-tooling ? (as its not really a 'processor' any more - that was a legacy name from JBS)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For that matter, the konflux-processor value is then used to fill out JVM_BUILD_SERVICE_REQPROCESSOR_IMAGE but that comes from now https://quay.io/repository/redhat-user-workloads/konflux-jbs-pnc-tenant/konflux-tooling?tab=tags&tag=latest so potentially that also should be renamed (but that is scattered across various places so is more complex to handle)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For renaming JVM_BUILD_SERVICE_REQPROCESSOR_IMAGE ; see JBS-79

Copy link
Contributor Author

@rnc rnc Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've renamed konflux-processor to pnc-konflux-tooling in the subsequent commit.

# TODO: This will eventually be build-definitions repository
pipeline-resolver: "https://raw.githubusercontent.com/redhat-appstudio/jvm-build-service/refs/heads/main/deploy/pipeline/mw-pipeline-v0.1.yaml"
indy-proxy-enabled: false
Expand Down
Loading