Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use konflux-jbs-pnc-tenant/konflux-tooling image #8

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

rnc
Copy link
Contributor

@rnc rnc commented Dec 19, 2024

No description provided.

@@ -1,6 +1,6 @@
konflux-build-driver:
quay-repo: "quay.io/redhat-user-workloads-stage/pnc-devel-tenant/pnc-konflux"
konflux-processor: "quay.io/redhat-user-workloads/konflux-jbs-pnc-tenant/jvm-build-service/build-request-processor:latest"
konflux-processor: "quay.io/redhat-user-workloads/konflux-jbs-pnc-tenant/konflux-tooling:latest"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matejonnet I wonder if we should rename this configuration option to e.g. pnc-tooling ? (as its not really a 'processor' any more - that was a legacy name from JBS)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For that matter, the konflux-processor value is then used to fill out JVM_BUILD_SERVICE_REQPROCESSOR_IMAGE but that comes from now https://quay.io/repository/redhat-user-workloads/konflux-jbs-pnc-tenant/konflux-tooling?tab=tags&tag=latest so potentially that also should be renamed (but that is scattered across various places so is more complex to handle)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For renaming JVM_BUILD_SERVICE_REQPROCESSOR_IMAGE ; see JBS-79

Copy link
Contributor Author

@rnc rnc Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've renamed konflux-processor to pnc-konflux-tooling in the subsequent commit.

@rnc rnc requested a review from matejonnet December 27, 2024 10:30
@rnc rnc marked this pull request as ready for review January 9, 2025 10:52
@rnc rnc merged commit 36fe430 into project-ncl:main Jan 13, 2025
2 checks passed
@rnc rnc deleted the BR1 branch January 13, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants