Add likelihood experiments to main repo #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This PR: - fixes many ruff linter errors, removing unused imports and variables - disables ruff formatting and linting for ipynb files I verified that all tests pass on a cloud VM.
<!--pre-commit.ci start--> updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.2 → v0.5.4](astral-sh/ruff-pre-commit@v0.5.2...v0.5.4) <!--pre-commit.ci end--> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sam Ritchie <[email protected]>
This PR moves all code into a `src` directory, instead of the current flat package structure. This is a prerequisite for the reproducible build that @eightysteele is working on, and is a good change anyway for a project destined to become a library.
This PR ports setup.py to pyproject.toml; this is the modern, recommended way to configure python projects, and gives us a way to add proper settings to things like linting, type-checking etc that match the other projects at probcomp. I've checked that the tests all run to the same failure as on main, the scripts are all installed correctly, the versioning works well etc.
This PR: - Upgrades b3d to https://github.com/probcomp/genjax/releases/tag/v0.5.0 - escapes math backslashes in python strings - these were causing "unsupported literal" exceptions on import GenJAX 0.5.0 doesn't break anything that b3d uses, and includes some nice-to-have type upgrades that will make development a bit more pleasant.
This PR: - turns on the ruff configuration that we're using for genjax - adds it to the pre-commit hooks - auto-fixes most errors (unsorted imports, unused local variables etc) - manually fixes the last few
@sritchie @nishadgothoskar after this change, run_tests.sh passes on my machine.
… likelihood_experiments
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make likelihood experiments more visible to rest of chi-sight