Fix a bug in truncated Laplace's logpdf compute #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
sritchie
reviewed
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My bad. I was trying to be smart and switched to use
logcdfinstead of regularcdfin #142, but I wasn't super careful when I changed the function calls, and ended up changing1 - cdf(val)->1 - log_cdf(val), which means totally different things. This is fixed by callinglog_survival_function(val)instead.I've verified that with this fix, the two failing tests in #142 now successfully runs.
As a side note, it's really great that we have good tests and CI to catch small bugs like this! Otherwise it could've took me ages to figure out why the model isn't working as we expected. :)