Fix a bug in truncated Laplace's logpdf compute (#143)

probcomp · Sep 7, 2024 · 9436068 · 9436068
1 parent 4568412
commit 9436068
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/b3d/chisight/dynamic_object_model/likelihoods/kfold_image_kernel.py b/src/b3d/chisight/dynamic_object_model/likelihoods/kfold_image_kernel.py
@@ -82,9 +82,9 @@ def logpdf(self, obs, loc, scale, low, high, uniform_window_size):
         assert low + uniform_window_size < high - uniform_window_size
         laplace_logpdf = tfp.distributions.Laplace(loc, scale).log_prob(obs)
         laplace_logp_below_low = tfp.distributions.Laplace(loc, scale).log_cdf(low)
-        laplace_logp_above_high = 1 - tfp.distributions.Laplace(loc, scale).log_cdf(
-            high
-        )
+        laplace_logp_above_high = tfp.distributions.Laplace(
+            loc, scale
+        ).log_survival_function(high)
         log_window_size = jnp.log(uniform_window_size)
 
         return jnp.where(