Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link variant snippets for svelte #1516

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Add link variant snippets for svelte #1516

merged 1 commit into from
Dec 19, 2024
+12 −6

Conversation

dani-mp
Copy link
Contributor

@dani-mp dani-mp commented Dec 18, 2024

Depends on #1515. Review that one first.

Resolves:
https://linear.app/prismic/issue/DT-2469/aauser-when-i-create-a-link-field-and-allow-variants-i-can-see-an

Description

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment. ↩

@dani-mp dani-mp requested a review from a team as a code owner December 18, 2024 19:34
@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Dec 18, 2024 7:40pm

@dani-mp dani-mp mentioned this pull request Dec 19, 2024
Merged
4 tasks
xrutayisire
xrutayisire approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@xrutayisire xrutayisire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Base automatically changed from dani/link-variant-9 to dani/link-variant December 19, 2024 18:14
@dani-mp dani-mp merged commit 4488860 into dani/link-variant Dec 19, 2024
32 of 33 checks passed
@dani-mp dani-mp deleted the dani/link-variant-10 branch December 19, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrutayisire xrutayisire xrutayisire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dani-mp @xrutayisire