Track link variants property when field is added #1517
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -210,6 +210,7 @@ type FieldAddedSegmentEvent = SegmentEvent< | |||
| contentType: "page type" | "custom type" | "slice"; | |||
| allowText?: boolean; | |||
| repeat?: boolean; | |||
| variants?: string[]; | |||
There was a problem hiding this comment.
❓ Interesting, so we can send an array directly to Segment / Amplitude? How does it's translated in Amplitude, as a string?
There was a problem hiding this comment.
not sure how it gets in amplitude, but it reaches segment as it should (see debugger screenshot)
There was a problem hiding this comment.
Actually that's so coooool, I just checked on Amplitude your event!
It allows Côme to say: I want to check all that contain Primary, or those you have exactly Primary and Secondary, etc etc.
There was a problem hiding this comment.
irrc, the page builder team has some weird types for tracking events, only allowing strings
maybe it's because of the proxy we use, idk
but both segment and amplitude allow strings, numbers, arrays, booleans... which could improve a lot our analytics, imo
Depends on #1516. Review that one first.
Resolves:
https://linear.app/prismic/issue/DT-2473/aapm-i-can-see-a-property-to-the-event-slice-machine-field-added-type
Description
Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩