-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated infra privacy to support privacy set up #56
Changes from 11 commits
66a821e
a56bfe3
e7b44aa
40af364
2bfb887
d0a2bae
b2b4b88
01bd862
242a571
8e70903
1ffd114
290f0f8
47e8d3a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ job "{{ job.name }}" { | |
mode = "bridge" | ||
|
||
dns { | ||
servers = {{ ansible_facts['dns']['nameservers'] | tojson }} | ||
servers = {{ (ansible_facts['dns']['nameservers'] + ['1.1.1.1']) | tojson }} | ||
} | ||
|
||
{% for port_name, port_details in job.ports[0].items() %} | ||
|
@@ -57,13 +57,7 @@ job "{{ job.name }}" { | |
{{- end }} | ||
{% endraw %} | ||
{% if job.target_type == 'bidder' %} | ||
{%- raw %} | ||
{{ range nomadService "mev-commit-geth-bootnode1" }} | ||
{{- if contains "http" .Tags }} | ||
EMULATOR_SETTLEMENT_RPC_ENDPOINT="http://{{ .Address }}:{{ .Port }}" | ||
{{ end }} | ||
{{ end }} | ||
{% endraw %} | ||
EMULATOR_L1_RPC_URL="{{ job.env['l1_rpc_url'] }}" | ||
{% endif %} | ||
EOH | ||
destination = "secrets/.env" | ||
|
@@ -86,10 +80,8 @@ job "{{ job.name }}" { | |
${EMULATOR_BINARY} \ | ||
-server-addr "${EMULATOR_IP_PORT}" \ | ||
{% if job.target_type == 'bidder' %} | ||
-rpc-addr "${EMULATOR_SETTLEMENT_RPC_ENDPOINT}" \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So the emulator was previously (incorrectly) querying the mev-commit chain instead of L1? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, we found out this with Alok |
||
-rpc-addr "${EMULATOR_L1_RPC_URL}" \ | ||
{% endif %} | ||
-log-tags "${EMULATOR_LOG_TAGS}" \ | ||
-log-fmt "${EMULATOR_LOG_FMT}" | ||
EOH | ||
destination = "local/run.sh" | ||
perms = "0755" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,11 @@ server_common_name: "mev-commit_{{ env }}.mev-commit.primev.xyz" | |
tls_crt_file: "{{ certificates_dir }}/{{ server_common_name }}.crt" | ||
tls_key_file: "{{ private_keys_dir }}/{{ server_common_name }}.key" | ||
tls_ca_crt_file: "{{ ca_certificates_dir }}/ca-{{ server_common_name }}.crt" | ||
preconf_contract_address: "0x2Aff805aBdF1Fe79AfcF8B3a9B4B45ECcD6b6D6e" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should avoid introducing another place that these addresses are hardcoded, and use one or the other. See https://github.com/primevprotocol/monorepo/blob/main/contracts-abi/config/testnet.go There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree with @shaspitz We should not hard-code the contract addresses for the testnet setup. We should have this mechanism for the devnet setup as we may deploy new set of contracts and they have to be tested. Not sure how to manage this with nomad though. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Got rid of hard-code addresses in nomad script |
||
blocktracker_contract_address: "0x042744D8cF66d8455350D43F9e09CA73b5C0CB94" | ||
oracle_contract_address: "0x77A4FE615de28fdf0bF68D9B9ba773A32b5C7630" | ||
bidder_registry_contract_address: "0x1E218818D409E0f00dfeBE8A960F7585d4fDff70" | ||
provider_registry_contract_address: "0x0332388390d9df01cA3d26269f2B1Fc314deD9c0" | ||
|
||
jobs: | ||
- name: datadog-agent-logs-collector | ||
|
@@ -26,6 +31,9 @@ jobs: | |
http: | ||
static: 8545 | ||
to: 8545 | ||
ws: | ||
static: 8546 | ||
to: 8546 | ||
p2p: | ||
to: 30301 | ||
env: | ||
|
@@ -49,21 +57,6 @@ jobs: | |
sync_mode: snap | ||
block_address: "0xd9cd8E5DE6d55f796D980B818D350C0746C25b97" | ||
|
||
- name: mev-commit-geth-signer-node2 | ||
template: mev-commit-geth.nomad.j2 | ||
count: 1 | ||
ports: | ||
- metrics: | ||
to: 6060 | ||
p2p: | ||
to: 30311 | ||
env: | ||
ip: 0.0.0.0 | ||
net_restrict: 0.0.0.0/0 | ||
type: signer | ||
sync_mode: snap | ||
block_address: "0x788EBABe5c3dD422Ef92Ca6714A69e2eabcE1Ee4" | ||
|
||
- name: mev-commit-geth-member-node | ||
template: mev-commit-geth.nomad.j2 | ||
count: 1 | ||
|
@@ -108,6 +101,10 @@ jobs: | |
type: bootnode | ||
tls_crt_file: "{{ tls_crt_file }}" | ||
tls_key_file: "{{ tls_key_file }}" | ||
preconf_contract_address: "{{ preconf_contract_address }}" | ||
blocktracker_contract_address: "{{ blocktracker_contract_address }}" | ||
bidder_registry_contract_address: "{{ bidder_registry_contract_address }}" | ||
provider_registry_contract_address: "{{ provider_registry_contract_address }}" | ||
|
||
- name: mev-commit-provider-node1 | ||
template: mev-commit.nomad.j2 | ||
|
@@ -130,13 +127,35 @@ jobs: | |
nat_address: "{{ ansible_facts['default_ipv4']['address'] }}" | ||
tls_crt_file: "{{ tls_crt_file }}" | ||
tls_key_file: "{{ tls_key_file }}" | ||
preconf_contract_address: "{{ preconf_contract_address }}" | ||
blocktracker_contract_address: "{{ blocktracker_contract_address }}" | ||
bidder_registry_contract_address: "{{ bidder_registry_contract_address }}" | ||
provider_registry_contract_address: "{{ provider_registry_contract_address }}" | ||
|
||
- name: mev-commit-provider-node1-funder | ||
template: mev-commit-funder.nomad.j2 | ||
count: 1 | ||
target_type: provider | ||
target_name: mev-commit-provider-node1 | ||
|
||
- name: mev-commit-oracle | ||
template: mev-commit-oracle.nomad.j2 | ||
count: 1 | ||
ports: | ||
- db: | ||
static: 5432 | ||
to: 5432 | ||
http: | ||
static: 8080 | ||
to: 8080 | ||
env: | ||
l1_rpc_url: https://ethereum-holesky-rpc.publicnode.com | ||
preconf_contract_address: "{{ preconf_contract_address }}" | ||
blocktracker_contract_address: "{{ blocktracker_contract_address }}" | ||
bidder_registry_contract_address: "{{ bidder_registry_contract_address }}" | ||
provider_registry_contract_address: "{{ provider_registry_contract_address }}" | ||
oracle_contract_address: "{{ oracle_contract_address }}" | ||
|
||
- name: mev-commit-bidder-node1 | ||
template: mev-commit.nomad.j2 | ||
count: 1 | ||
|
@@ -157,6 +176,10 @@ jobs: | |
type: bidder | ||
tls_crt_file: "{{ tls_crt_file }}" | ||
tls_key_file: "{{ tls_key_file }}" | ||
preconf_contract_address: "{{ preconf_contract_address }}" | ||
blocktracker_contract_address: "{{ blocktracker_contract_address }}" | ||
bidder_registry_contract_address: "{{ bidder_registry_contract_address }}" | ||
provider_registry_contract_address: "{{ provider_registry_contract_address }}" | ||
|
||
- name: mev-commit-bidder-node1-funder | ||
template: mev-commit-funder.nomad.j2 | ||
|
@@ -181,18 +204,8 @@ jobs: | |
ports: | ||
- metrics: | ||
to: 8080 | ||
|
||
- name: mev-commit-oracle | ||
template: mev-commit-oracle.nomad.j2 | ||
count: 1 | ||
ports: | ||
- db: | ||
static: 5432 | ||
to: 5432 | ||
http: | ||
to: 8080 | ||
env: | ||
l1_rpc_url: https://rpc.sepolia.org | ||
l1_rpc_url: https://ethereum-holesky-rpc.publicnode.com | ||
|
||
- name: mev-commit-bridge | ||
template: mev-commit-bridge.nomad.j2 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why this sleep time needed to be increased?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
180s were not enough, but with 240s it's more reliable; contracts have enough time to be deployed with that timing.