-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated infra privacy to support privacy set up #56
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
66a821e
fix: updating infra for privacy
Mikelle a56bfe3
fix: deleted secrets
Mikelle e7b44aa
fix: added raw
Mikelle 40af364
fix: updated nomad
Mikelle 2bfb887
fix: fixed job env
Mikelle d0a2bae
fix: fixing oracle nomad job
Mikelle b2b4b88
fix: updated order
Mikelle 01bd862
fix: updated infra
Mikelle 242a571
fix: deleted comment for datadog logs
Mikelle 8e70903
chore: merge branch 'main' into infra-privacy
Mikelle 1ffd114
fix: fixes after merge
Mikelle 290f0f8
Merge branch 'main' into infra-privacy
Mikelle 47e8d3a
chore: get rid of contracts hardcode
Mikelle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,13 +57,7 @@ job "{{ job.name }}" { | |
{{- end }} | ||
{% endraw %} | ||
{% if job.target_type == 'bidder' %} | ||
{%- raw %} | ||
{{ range nomadService "mev-commit-geth-bootnode1" }} | ||
{{- if contains "http" .Tags }} | ||
EMULATOR_SETTLEMENT_RPC_ENDPOINT="http://{{ .Address }}:{{ .Port }}" | ||
{{ end }} | ||
{{ end }} | ||
{% endraw %} | ||
EMULATOR_L1_RPC_URL="{{ job.env['l1_rpc_url'] }}" | ||
{% endif %} | ||
EOH | ||
destination = "secrets/.env" | ||
|
@@ -86,10 +80,8 @@ job "{{ job.name }}" { | |
${EMULATOR_BINARY} \ | ||
-server-addr "${EMULATOR_IP_PORT}" \ | ||
{% if job.target_type == 'bidder' %} | ||
-rpc-addr "${EMULATOR_SETTLEMENT_RPC_ENDPOINT}" \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So the emulator was previously (incorrectly) querying the mev-commit chain instead of L1? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, we found out this with Alok |
||
-rpc-addr "${EMULATOR_L1_RPC_URL}" \ | ||
{% endif %} | ||
-log-tags "${EMULATOR_LOG_TAGS}" \ | ||
-log-fmt "${EMULATOR_LOG_FMT}" | ||
EOH | ||
destination = "local/run.sh" | ||
perms = "0755" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why this sleep time needed to be increased?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
180s were not enough, but with 240s it's more reliable; contracts have enough time to be deployed with that timing.