Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implements partial slashing #402

Merged
merged 9 commits into from
Sep 17, 2024
Merged

feat: implements partial slashing #402

merged 9 commits into from
Sep 17, 2024

Conversation

ckartik
Copy link
Contributor

@ckartik ckartik commented Sep 15, 2024

Describe your changes

  • Fixes first identified bug by allowing partial slashing of provider funds in the event of insufficent funds in a providers stake balance.

@ckartik ckartik requested review from shaspitz and Mikelle September 15, 2024 19:41
@ckartik ckartik changed the title Ckartik/bug fix num 1 Implements partial slashing in the event of provider Insufficient balance Sep 15, 2024
shaspitz
shaspitz reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests will need to be fixed

contracts/contracts/core/ProviderRegistry.sol Show resolved Hide resolved
@ckartik ckartik force-pushed the ckartik/bug-fix-num-1 branch from 72088de to 840d446 Compare September 17, 2024 14:49
@ckartik ckartik changed the title Implements partial slashing in the event of provider Insufficient balance feat: Implements partial slashing in the event of provider Insufficient balance Sep 17, 2024
@ckartik ckartik changed the title feat: Implements partial slashing in the event of provider Insufficient balance feat: implements partial slashing in the event of provider insufficient balance Sep 17, 2024
@ckartik ckartik changed the title feat: implements partial slashing in the event of provider insufficient balance feat: implements partial slashing Sep 17, 2024
@ckartik ckartik requested a review from Mikelle September 17, 2024 15:08
@ckartik ckartik merged commit 8eb78b9 into main Sep 17, 2024
5 checks passed
@ckartik ckartik deleted the ckartik/bug-fix-num-1 branch September 17, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaspitz shaspitz shaspitz left review comments

@Mikelle Mikelle Mikelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckartik @Mikelle @shaspitz