feat: implements partial slashing (#402)

* feat: adds logic to mitigate against insufficent funds bug * feat: adds testing for edge cases of penatly and residual balance slashing * chore: newline * chore: remove whitespace * chore: constructs the provider registry abi * feat: start reducing storage reads Co-authored-by: Mikhail Wall <[email protected]> * feat: reduce storage reads * feat: fixes bug around not slashing the provider balance. * chore: remove empty line --------- Co-authored-by: Mikhail Wall <[email protected]>
primev · Sep 17, 2024 · 8eb78b9 · 8eb78b9
1 parent 4605509
commit 8eb78b9
Show file tree

Hide file tree

Showing 5 changed files with 243 additions and 5 deletions.
diff --git a/contracts-abi/abi/ProviderRegistry.abi b/contracts-abi/abi/ProviderRegistry.abi
@@ -668,6 +668,37 @@
     ],
     "anonymous": false
   },
+  {
+    "type": "event",
+    "name": "InsufficientFundsToSlash",
+    "inputs": [
+      {
+        "name": "provider",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      },
+      {
+        "name": "providerStake",
+        "type": "uint256",
+        "indexed": false,
+        "internalType": "uint256"
+      },
+      {
+        "name": "residualAmount",
+        "type": "uint256",
+        "indexed": false,
+        "internalType": "uint256"
+      },
+      {
+        "name": "penaltyFee",
+        "type": "uint256",
+        "indexed": false,
+        "internalType": "uint256"
+      }
+    ],
+    "anonymous": false
+  },
   {
     "type": "event",
     "name": "OwnershipTransferStarted",

diff --git a/contracts-abi/clients/ProviderRegistry/ProviderRegistry.go b/contracts-abi/clients/ProviderRegistry/ProviderRegistry.go
diff --git a/contracts/contracts/core/ProviderRegistry.sol b/contracts/contracts/core/ProviderRegistry.sol
@@ -121,7 +121,15 @@ contract ProviderRegistry is
     ) external nonReentrant onlyPreConfirmationEngine whenNotPaused {
         uint256 residualAmt = (amt * residualBidPercentAfterDecay * PRECISION) / PERCENT;
         uint256 penaltyFee = (residualAmt * uint256(feePercent) * PRECISION) / PERCENT;
-        require(providerStakes[provider] >= residualAmt + penaltyFee, "Insufficient funds to slash");
+        uint256 providerStake = providerStakes[provider];
+
+        if (providerStake < residualAmt + penaltyFee) {
+            emit InsufficientFundsToSlash(provider, providerStake, residualAmt, penaltyFee);
+            if (providerStake < residualAmt) {
+                residualAmt = providerStake;
+            }
+            penaltyFee = providerStake - residualAmt;
+        }
         providerStakes[provider] -= residualAmt + penaltyFee;
 
         penaltyFeeTracker.accumulatedAmount += penaltyFee;

diff --git a/contracts/contracts/interfaces/IProviderRegistry.sol b/contracts/contracts/interfaces/IProviderRegistry.sol
@@ -27,6 +27,14 @@ interface IProviderRegistry {
     /// @dev Event emitted when the fee payout period in blocks is updated
     event FeePayoutPeriodBlocksUpdated(uint256 indexed newFeePayoutPeriodBlocks);
 
+    /// @dev Event emitted when there are insufficient funds to slash
+    event InsufficientFundsToSlash(
+        address indexed provider,
+        uint256 providerStake,
+        uint256 residualAmount,
+        uint256 penaltyFee
+    );
+
     function registerAndStake(bytes calldata blsPublicKey) external payable;
 
     function stake() external payable;

diff --git a/contracts/test/core/ProviderRegistryTest.sol b/contracts/test/core/ProviderRegistryTest.sol
@@ -28,6 +28,12 @@ contract ProviderRegistryTest is Test {
     event FeeTransfer(uint256 amount, address indexed recipient);
     event PenaltyFeeRecipientUpdated(address indexed newPenaltyFeeRecipient);
     event FeePayoutPeriodBlocksUpdated(uint256 indexed newFeePayoutPeriodBlocks);
+    event InsufficientFundsToSlash(
+        address indexed provider,
+        uint256 providerStake,
+        uint256 residualAmt,
+        uint256 penaltyFee
+    );
 
     function setUp() public {
         testNumber = 42;
@@ -257,21 +263,59 @@ contract ProviderRegistryTest is Test {
         vm.expectRevert(bytes(""));
         providerRegistry.slash(1 ether, provider, payable(bidder),100);
     }
-
-    function testFail_ShouldRetrieveFundsGreaterThanStake() public {
+    function test_ShouldRetrieveFundsWhenSlashIsGreaterThanStake() public {
         vm.prank(address(this));
         providerRegistry.setPreconfirmationsContract(address(this));
 
         vm.deal(provider, 3 ether);
         vm.prank(provider);
         providerRegistry.registerAndStake{value: 2 ether}(validBLSPubkey);
         address bidder = vm.addr(4);
-        vm.expectRevert(bytes(""));
         vm.prank(address(this));
 
+        vm.expectEmit(true, true, true, true);
+        emit InsufficientFundsToSlash(provider, 2 ether, 3 ether, 0.3 ether);
+        providerRegistry.slash(3 ether, provider, payable(bidder), 100);
+
+        assertEq(providerRegistry.getAccumulatedPenaltyFee(), 0);
+        assertEq(providerRegistry.providerStakes(provider), 0 ether);
+    }
+
+    function test_ShouldRetrieveFundsWhenSlashIsGreaterThanStakePenaltyNotCovered() public {
+        vm.prank(address(this));
+        providerRegistry.setPreconfirmationsContract(address(this));
+
+        vm.deal(provider, 3 ether);
+        vm.prank(provider);
+        providerRegistry.registerAndStake{value: 3 ether}(validBLSPubkey);
+        address bidder = vm.addr(4);
+        vm.prank(address(this));
+
+        vm.expectEmit(true, true, true, true);
+        emit InsufficientFundsToSlash(provider, 3 ether, 3 ether, 0.3 ether);
         providerRegistry.slash(3 ether, provider, payable(bidder), 100);
+
+        assertEq(providerRegistry.getAccumulatedPenaltyFee(), 0);
+        assertEq(providerRegistry.providerStakes(provider), 0 ether);
     }
 
+    function test_ShouldRetrieveFundsWhenSlashIsGreaterThanStakePenaltyNotFullyCovered() public {
+        vm.prank(address(this));
+        providerRegistry.setPreconfirmationsContract(address(this));
+
+        vm.deal(provider, 3.1 ether);
+        vm.prank(provider);
+        providerRegistry.registerAndStake{value: 3.1 ether}(validBLSPubkey);
+        address bidder = vm.addr(4);
+        vm.prank(address(this));
+
+        vm.expectEmit(true, true, true, true);
+        emit InsufficientFundsToSlash(provider, 3.1 ether, 3 ether, 0.3 ether);
+        providerRegistry.slash(3 ether, provider, payable(bidder), 100);
+
+        assertEq(providerRegistry.getAccumulatedPenaltyFee(), 0.1 ether);
+        assertEq(providerRegistry.providerStakes(provider), 0 ether);
+    }
     function test_PenaltyFeeBehavior() public {
         providerRegistry.setNewPenaltyFeeRecipient(vm.addr(6));
         vm.deal(provider, 3 ether);