chore: introduce solhint linter + fixes

.github/workflows/ci.yml

@@ -188,6 +188,9 @@ jobs:
 
       - name: Install Hardhat
         run: npm install -g hardhat
+
+      - name: Install solhint
+        run: npm install -g solhint
 
       - name: Install Dependencies
         run: npm install
@@ -198,6 +201,7 @@ jobs:
           node --version
           npm --version
           forge --version
+          solhint --version
 
       - name: Build
         run: npm run build --if-present
@@ -216,6 +220,10 @@ jobs:
           git diff --name-only --exit-code . || (echo "Generated files not in parity with the source files." && exit 1)
           git reset --hard HEAD
         working-directory: contracts-abi
+
+      - name: Run solhint solidity linter
+        run: make solhint
+        working-directory: contracts
 
   infrastructure:
     uses: ./.github/workflows/infrastructure.yml

contracts-abi/abi/BidderRegistry.abi

@@ -82,6 +82,13 @@
     ],
     "stateMutability": "view"
   },
+  {
+    "type": "function",
+    "name": "acceptOwnership",
+    "inputs": [],
+    "outputs": [],
+    "stateMutability": "nonpayable"
+  },
   {
     "type": "function",
     "name": "bidderRegistered",
@@ -342,6 +349,19 @@
     ],
     "stateMutability": "view"
   },
+  {
+    "type": "function",
+    "name": "pendingOwner",
+    "inputs": [],
+    "outputs": [
+      {
+        "name": "",
+        "type": "address",
+        "internalType": "address"
+      }
+    ],
+    "stateMutability": "view"
+  },
   {
     "type": "function",
     "name": "preConfirmationsContract",
@@ -742,6 +762,25 @@
     ],
     "anonymous": false
   },
+  {
+    "type": "event",
+    "name": "OwnershipTransferStarted",
+    "inputs": [
+      {
+        "name": "previousOwner",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      },
+      {
+        "name": "newOwner",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      }
+    ],
+    "anonymous": false
+  },
   {
     "type": "event",
     "name": "OwnershipTransferred",

contracts-abi/abi/BlockTracker.abi

@@ -25,6 +25,13 @@
     ],
     "stateMutability": "view"
   },
+  {
+    "type": "function",
+    "name": "acceptOwnership",
+    "inputs": [],
+    "outputs": [],
+    "stateMutability": "nonpayable"
+  },
   {
     "type": "function",
     "name": "addBuilderAddress",
@@ -202,6 +209,19 @@
     ],
     "stateMutability": "view"
   },
+  {
+    "type": "function",
+    "name": "pendingOwner",
+    "inputs": [],
+    "outputs": [
+      {
+        "name": "",
+        "type": "address",
+        "internalType": "address"
+      }
+    ],
+    "stateMutability": "view"
+  },
   {
     "type": "function",
     "name": "proxiableUUID",
@@ -322,6 +342,25 @@
     ],
     "anonymous": false
   },
+  {
+    "type": "event",
+    "name": "OwnershipTransferStarted",
+    "inputs": [
+      {
+        "name": "previousOwner",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      },
+      {
+        "name": "newOwner",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      }
+    ],
+    "anonymous": false
+  },
   {
     "type": "event",
     "name": "OwnershipTransferred",

contracts-abi/abi/L1Gateway.abi

@@ -21,6 +21,13 @@
     ],
     "stateMutability": "view"
   },
+  {
+    "type": "function",
+    "name": "acceptOwnership",
+    "inputs": [],
+    "outputs": [],
+    "stateMutability": "nonpayable"
+  },
   {
     "type": "function",
     "name": "counterpartyFee",
@@ -135,6 +142,19 @@
     ],
     "stateMutability": "view"
   },
+  {
+    "type": "function",
+    "name": "pendingOwner",
+    "inputs": [],
+    "outputs": [
+      {
+        "name": "",
+        "type": "address",
+        "internalType": "address"
+      }
+    ],
+    "stateMutability": "view"
+  },
   {
     "type": "function",
     "name": "proxiableUUID",
@@ -238,6 +258,25 @@
     ],
     "anonymous": false
   },
+  {
+    "type": "event",
+    "name": "OwnershipTransferStarted",
+    "inputs": [
+      {
+        "name": "previousOwner",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      },
+      {
+        "name": "newOwner",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      }
+    ],
+    "anonymous": false
+  },
   {
     "type": "event",
     "name": "OwnershipTransferred",

contracts-abi/abi/MevCommitAVS.abi

@@ -25,6 +25,13 @@
     ],
     "stateMutability": "view"
   },
+  {
+    "type": "function",
+    "name": "acceptOwnership",
+    "inputs": [],
+    "outputs": [],
+    "stateMutability": "nonpayable"
+  },
   {
     "type": "function",
     "name": "avsDirectory",
@@ -523,6 +530,19 @@
     ],
     "stateMutability": "view"
   },
+  {
+    "type": "function",
+    "name": "pendingOwner",
+    "inputs": [],
+    "outputs": [
+      {
+        "name": "",
+        "type": "address",
+        "internalType": "address"
+      }
+    ],
+    "stateMutability": "view"
+  },
   {
     "type": "function",
     "name": "proxiableUUID",
@@ -1191,6 +1211,25 @@
     ],
     "anonymous": false
   },
+  {
+    "type": "event",
+    "name": "OwnershipTransferStarted",
+    "inputs": [
+      {
+        "name": "previousOwner",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      },
+      {
+        "name": "newOwner",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      }
+    ],
+    "anonymous": false
+  },
   {
     "type": "event",
     "name": "OwnershipTransferred",
@@ -1464,11 +1503,21 @@
     "name": "FailedInnerCall",
     "inputs": []
   },
+  {
+    "type": "error",
+    "name": "InvalidFallback",
+    "inputs": []
+  },
   {
     "type": "error",
     "name": "InvalidInitialization",
     "inputs": []
   },
+  {
+    "type": "error",
+    "name": "InvalidReceive",
+    "inputs": []
+  },
   {
     "type": "error",
     "name": "NotInitializing",

contracts-abi/abi/Oracle.abi

@@ -25,6 +25,13 @@
     ],
     "stateMutability": "view"
   },
+  {
+    "type": "function",
+    "name": "acceptOwnership",
+    "inputs": [],
+    "outputs": [],
+    "stateMutability": "nonpayable"
+  },
   {
     "type": "function",
     "name": "blockBuilderNameToAddress",
@@ -80,6 +87,19 @@
     ],
     "stateMutability": "view"
   },
+  {
+    "type": "function",
+    "name": "pendingOwner",
+    "inputs": [],
+    "outputs": [
+      {
+        "name": "",
+        "type": "address",
+        "internalType": "address"
+      }
+    ],
+    "stateMutability": "view"
+  },
   {
     "type": "function",
     "name": "processBuilderCommitmentForBlockNumber",
@@ -196,6 +216,25 @@
     ],
     "anonymous": false
   },
+  {
+    "type": "event",
+    "name": "OwnershipTransferStarted",
+    "inputs": [
+      {
+        "name": "previousOwner",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      },
+      {
+        "name": "newOwner",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      }
+    ],
+    "anonymous": false
+  },
   {
     "type": "event",
     "name": "OwnershipTransferred",