Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open table option #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Open table option #18

wants to merge 1 commit into from

Conversation

mavit
Copy link
Contributor

@mavit mavit commented Nov 20, 2020

Addresses #17.

@mavit mavit mentioned this pull request Nov 21, 2020
Open
@mavit
Add an option to immediately open the table for joining
6c66784 
Validate the new `open` option as some style of boolean, applying it last.

Rebased against latest master.
@mavit mavit force-pushed the open-table-option branch from b293e1b to 6c66784 Compare December 24, 2020 16:35
@pocc
Copy link
Owner

pocc commented Feb 26, 2021

Sorry for the late response on this. I agree that open should be the default. Is it possible to get rid of the open:true parsing and just check for an open:falsy option?

@mavit
Copy link
Contributor Author

mavit commented Feb 28, 2021

My perhaps mistaken understanding was that the discussion in #17 (comment) ended with us agreeing that the table should be opened by default only if restrictgroup is set. If the default for open is conditional on restrictgroup, then we want a way for the user to override open in either direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mavit @pocc