Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tables to be opened #17

Open
mavit opened this issue Nov 20, 2020 · 6 comments
Open

Allow tables to be opened #17

mavit opened this issue Nov 20, 2020 · 6 comments

Comments

@mavit
Copy link
Contributor

mavit commented Nov 20, 2020

Sometimes, it is more convenient to open a table and allow players to add themselves than it is to individually invite each participant.

It would be helpful if the bot was able to open a table, either via a command, an option to make, or both.

@pocc
Copy link
Owner

pocc commented Nov 20, 2020

Having the table be manually opened I think is something that is required for non-realtime games. Why not automatically open games if applicable?

I can't imagine that someone would want to use open:no.

@mavit
Copy link
Contributor Author

mavit commented Nov 20, 2020

Having the table be manually opened I think is something that is required for non-realtime games. Why not automatically open games if applicable?

Seems risky. You're not asked again to confirm participation in a turn-based game, so you probably don't want to open it until all players have accepted. I believe that if the table is open and an invitee declines, someone else could take their place, which is likely to not be what you wanted if you forgot to set restrictgroup.

I can't imagine that someone would want to use open:no.

Indeed not, but all existing options take values so it seemed most consistent to stick to that pattern. This does lead me to wonder if argparse would be a better approach than manually parsing messages, though.

@pocc
Copy link
Owner

pocc commented Nov 20, 2020

Argparse is possible, but not really necessary - I think moving away from a command line model and more toward an interactive model would be good. Take a look at apollo.fyi - that's a nice UI right there.

Why not add BGA friends for all added players to games so that the default restriction can be myfriends (therefore preventing randos from joining)? That way, default opening has no issues.

@mavit
Copy link
Contributor Author

mavit commented Nov 21, 2020

Why not add BGA friends for all added players to games so that the default restriction can be myfriends (therefore preventing randos from joining)?

Iʼm not sure about that. I think some users might find it unexpected and unwelcome that the bot would modify their BGA friends. Plus, it depends on my inviting participants from Discord, whereas sometimes I may want to make the table in Discord then let players click the link to join themselves.

But yes, I do think it would be reasonable to default open to true if restrictgroup is set, and I can add that to pull request #18 if you like. I'm just not sure about setting restrictgroup by default.

@pocc
Copy link
Owner

pocc commented Nov 28, 2020

This seems like an option that can be added to the interactive setup.

@pocc
Copy link
Owner

pocc commented Dec 11, 2020

I didn't end up adding it to the interactive setup, but it shouldn't be too hard to add if this code is merged.

But yes, I do think it would be reasonable to default open to true if restrictgroup is set, and I can add that to pull request #18 if you like. I'm just not sure about setting restrictgroup by default.

I think this is a good idea.

mavit added a commit to mavit/bga_discord that referenced this issue Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants