Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge improve/action-execute #2509

Merged
merged 39 commits into from
Apr 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
7184e92
Use modern account in DailyReward
ipdae Mar 28, 2024
a22500f
Use const value instead of GameConfigState
ipdae Mar 28, 2024
9c0ad06
Apply review suggestions
ipdae Mar 29, 2024
848d559
Merge pull request #2495 from planetarium/refactor/issue-2478
ipdae Mar 29, 2024
82c37f5
remove unnecessary action point validating at ItemEnhancement
sonohoshi Mar 29, 2024
b7933df
remove abnormal GetRequiredAp invoking
sonohoshi Mar 29, 2024
ea5897f
use ActionPointModule at ChargeActionPoint
sonohoshi Mar 29, 2024
884a9d4
reflect ChargeActionPoint hardfork to unit test
sonohoshi Mar 29, 2024
10a0651
use ActionPointModule at CombinationEquipment
sonohoshi Mar 29, 2024
ff2465b
reflect CombinationEquipment hardfork to unit test
sonohoshi Mar 29, 2024
62c6b62
use ActionPointModule at CombinationConsumable
sonohoshi Mar 29, 2024
77aaa3c
reflect CombinationConsumable hardfork to unit test
sonohoshi Mar 29, 2024
d7b6f51
use ActionPointModule at EventConsumableItemCrafts
sonohoshi Mar 29, 2024
cba4854
reflect EventConsumableItemCrafts hardfork to unit test
sonohoshi Mar 29, 2024
a50cf1a
use ActionPointModule at Grinding
sonohoshi Mar 29, 2024
bb77215
reflect Grinding hardfork to unit test
sonohoshi Mar 29, 2024
55822a3
use ActionPointModule at HackAndSlash
sonohoshi Apr 1, 2024
98642c6
reflect HackAndSlash hardfork to unit test
sonohoshi Apr 1, 2024
3ae2140
use ActionPointModule at HackAndSlashSweep
sonohoshi Apr 1, 2024
e101c0a
reflect HackAndSlashSweep hardfork to unit test
sonohoshi Apr 1, 2024
3b170dd
move AvatarState.UseAp to InventoryExtensions.UseActionPoint
sonohoshi Apr 1, 2024
6a5c4f3
use Inventory.UseActionPoint instead AvatarState.UseAp
sonohoshi Apr 1, 2024
0f1b5a0
remove unit test about AvatarState.UseAp()
sonohoshi Apr 1, 2024
491eaee
add unit test about InventoryExtensions.UseActionPoint
sonohoshi Apr 1, 2024
705eb2b
change GameConfigState.ActionPointMax to DailyReward.ActionPointMax
sonohoshi Apr 1, 2024
3b7b0c9
remove obsoleted action ReRegisterProduct0
sonohoshi Apr 1, 2024
f377b88
revoke RegisterProduct0
sonohoshi Apr 1, 2024
ec37aad
fix broken unit tests about ActionPoint hard-forking
sonohoshi Apr 1, 2024
0a1f649
add SetActionPoint() to CreateAvatar
sonohoshi Apr 1, 2024
1a1eccb
add Assert.Equal about ActionPointModule with CreateAvatar
sonohoshi Apr 1, 2024
9add03b
remove unnecessary code
sonohoshi Apr 1, 2024
031cdb5
reflect on review about SetDailyRewardReceivedBlockIndex
sonohoshi Apr 2, 2024
92d1db5
add ActionPointModule.TryGetActionPoint()
sonohoshi Apr 2, 2024
b07fa6a
fix InventoryExtensions.UseActionPoint()
sonohoshi Apr 2, 2024
cfd092b
fix InventoryExtensionsTest for changed interface
sonohoshi Apr 2, 2024
129faf3
fix many actions for passive-state migration
sonohoshi Apr 2, 2024
9f98111
fix unit tests, use TryGetActionPoint
sonohoshi Apr 2, 2024
1dcb552
Merge pull request #2502 from planetarium/migrate/for-action-point
sonohoshi Apr 2, 2024
f7c4236
Merge branch 'development' into improve/action-execute
ipdae Apr 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add SetActionPoint() to CreateAvatar
  • Loading branch information
sonohoshi committed Apr 1, 2024
commit 0a1f649b5b0b0e20e13c89b52201defb4ba38811
3 changes: 2 additions & 1 deletion Lib9c/Action/CreateAvatar.cs
Original file line number Diff line number Diff line change
@@ -238,7 +238,8 @@ public override IWorld Execute(IActionContext context)
Log.Debug("{AddressesHex}CreateAvatar Total Executed Time: {Elapsed}", addressesHex, ended - started);
return states
.SetAgentState(signer, agentState)
.SetAvatarState(avatarAddress, avatarState);
.SetAvatarState(avatarAddress, avatarState)
.SetActionPoint(avatarAddress, DailyReward.ActionPointMax);
}

public static void AddItem(ItemSheet itemSheet, CreateAvatarItemSheet createAvatarItemSheet,