-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge improve/action-execute #2509
Conversation
- rename args - remove unused args
DailyReward 실행속도 향상
더 이상 AvatarState에 있을 필요가 없어 역할을 옮겼습니다.
액션 하드포킹 테스트를 위해 쓰이고 있어서 동작을 이전과 같이 다시 수정했습니다
Validator 코드를 안쓴지 한참됐는데 usage를 갖고있어서 헷갈립니다.
at CreateAvatar action
do not SetState, return calculated result.
if can not get action point, use avatarState.actionPoint. and use ActionPointModule.SetActionPoint().
Migrate `AvatarState.actionPoint` to use `ActionPointModule`
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
merge improve/action-execute