Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop inline panel starter brick #8723

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Drop inline panel starter brick #8723

merged 6 commits into from
Jun 28, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jun 28, 2024

What does this PR do?

  • Drops inline panel starter brick and related code
  • Where applicable, tests switched to using Sidebar Panel

Reviewer Notes

  • Is a backward incompatible change. There's no production usage of inline panels. Inline panels were never made GA because: 1) point and click insertion was hard to get working, 2) rendering issues on some sites depending on front-end framework (including rendering infinite loops), 3) most users preferred sidebar due to interfaces already being cluttered

Remaining Work

  • Fix flaky Jest snapshot test. (Snapshots contains some sequence numbers)

For more information on our expectations for the PR process, see the
code review principles doc

Copy link

github-actions bot commented Jun 28, 2024

Playwright test results

passed  80 passed
skipped  2 skipped

Details

report  Open report ↗︎
stats  82 tests across 29 suites
duration  34 minutes, 34 seconds
commit  f0460a5

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@twschiller twschiller marked this pull request as ready for review June 28, 2024 16:28
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.07%. Comparing base (c32e86f) to head (f0460a5).
Report is 60 commits behind head on main.

Files Patch % Lines
src/pageEditor/panes/insert/useAutoInsert.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8723      +/-   ##
==========================================
+ Coverage   73.69%   74.07%   +0.37%     
==========================================
  Files        1344     1342       -2     
  Lines       41566    41388     -178     
  Branches     7775     7754      -21     
==========================================
+ Hits        30633    30659      +26     
+ Misses      10933    10729     -204     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller enabled auto-merge (squash) June 28, 2024 17:31
@twschiller twschiller merged commit 149f2ad into main Jun 28, 2024
21 checks passed
@twschiller twschiller deleted the feature/drop-inline-panel branch June 28, 2024 17:39
@grahamlangford grahamlangford added this to the 2.0.4 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants