Drop inline panel starter brick (#8723)

eslint-local-rules/persistBackgroundData.txt

@@ -216,7 +216,6 @@
 ./src/sidebar/RendererComponent.tsx
 ./src/starterBricks/contextMenu.ts
 ./src/starterBricks/contextMenuReader.ts
-./src/starterBricks/dom.tsx
 ./src/starterBricks/factory.ts
 ./src/starterBricks/helpers.ts
 ./src/starterBricks/menuItemExtension.ts

src/bricks/PipelineVisitor.test.ts

@@ -186,7 +186,7 @@ test("should invoke the callback for the Document button pipeline", () => {
   }
   const visitor = new Visitor();
   visitor.visitRootPipeline(pipeline, {
-    extensionPointType: StarterBrickTypes.INLINE_PANEL,
+    extensionPointType: StarterBrickTypes.SIDEBAR_PANEL,
   });
 
   expect(visitBlock).toHaveBeenCalledTimes(2); // One Document brick and one brick in the pipeline

src/components/BrickIcon.tsx

@@ -32,7 +32,6 @@ import {
 import { TriggerStarterBrickABC } from "@/starterBricks/trigger/triggerStarterBrick";
 import { ButtonStarterBrickABC } from "@/starterBricks/button/buttonStarterBrick";
 import { ContextMenuStarterBrickABC } from "@/starterBricks/contextMenu/contextMenuStarterBrick";
-import { PanelStarterBrickABC } from "@/starterBricks/panel/panelStarterBrick";
 import { SidebarStarterBrickABC } from "@/starterBricks/sidebar/sidebarStarterBrick";
 import getType from "@/runtime/getType";
 import { type BrickType } from "@/runtime/runtimeTypes";
@@ -83,10 +82,6 @@ function getDefaultBrickIcon<T extends Metadata>(
     return faBars;
   }
 
-  if (brick instanceof PanelStarterBrickABC) {
-    return faWindowMaximize;
-  }
-
   if (brick instanceof SidebarStarterBrickABC) {
     return faColumns;
   }

src/contentScript/messenger/api.ts

@@ -79,7 +79,6 @@ export const reloadMarketplaceEnhancements = getMethod(
 export const getAttributeExamples = getMethod("GET_ATTRIBUTE_EXAMPLES");
 export const selectElement = getMethod("SELECT_ELEMENT");
 
-export const insertPanel = getMethod("INSERT_PANEL");
 export const insertButton = getMethod("INSERT_BUTTON");
 export const enableOverlay = getMethod("ENABLE_OVERLAY");
 export const disableOverlay = getMethod("DISABLE_OVERLAY");

src/contentScript/messenger/registration.ts

@@ -48,7 +48,6 @@ import { cancelSelect } from "@/contentScript/pageEditor/elementPicker";
 import { reloadActivationEnhancements } from "@/contentScript/loadActivationEnhancementsCore";
 import { getAttributeExamples } from "@/contentScript/pageEditor/elementInformation";
 import selectElement from "@/contentScript/pageEditor/selectElement";
-import { insertPanel } from "@/contentScript/pageEditor/insertPanel";
 import { insertButton } from "@/contentScript/pageEditor/insertButton";
 import {
   disableOverlay,
@@ -105,7 +104,6 @@ declare global {
     RELOAD_MARKETPLACE_ENHANCEMENTS: typeof reloadActivationEnhancements;
     GET_ATTRIBUTE_EXAMPLES: typeof getAttributeExamples;
     SELECT_ELEMENT: typeof selectElement;
-    INSERT_PANEL: typeof insertPanel;
     INSERT_BUTTON: typeof insertButton;
     ENABLE_OVERLAY: typeof enableOverlay;
     DISABLE_OVERLAY: typeof disableOverlay;
@@ -159,7 +157,6 @@ export default function registerMessenger(): void {
     RELOAD_MARKETPLACE_ENHANCEMENTS: reloadActivationEnhancements,
     GET_ATTRIBUTE_EXAMPLES: getAttributeExamples,
     SELECT_ELEMENT: selectElement,
-    INSERT_PANEL: insertPanel,
     INSERT_BUTTON: insertButton,
     ENABLE_OVERLAY: enableOverlay,
     DISABLE_OVERLAY: disableOverlay,

src/contentScript/pageEditor/types.ts

@@ -21,10 +21,6 @@ import {
 } from "@/starterBricks/types";
 import { type StarterBrickType } from "@/types/starterBrickTypes";
 import { type Except } from "type-fest";
-import {
-  type PanelConfig,
-  type PanelDefinition,
-} from "@/starterBricks/panel/panelStarterBrickTypes";
 import {
   type ButtonDefinition,
   type ButtonStarterBrickConfig,
@@ -46,15 +42,6 @@ export interface DraftModComponent<
 }
 
 export type SelectMode = "element" | "container";
-export type PanelSelectionResult = {
-  uuid: UUID;
-  foundation: Except<
-    PanelDefinition,
-    "defaultOptions" | "isAvailable" | "reader"
-  >;
-  panel: Except<PanelConfig, "body">;
-  containerInfo: ElementInfo;
-};
 export type DraftButtonModComponent = DraftModComponent<
   ButtonDefinition,
   ButtonStarterBrickConfig

src/pageEditor/PanelContent.tsx

@@ -38,15 +38,17 @@ import { shouldAutoRun } from "@/pageEditor/toolbar/ReloadToolbar";
 import ReduxPersistenceContext, {
   type ReduxPersistenceContextType,
 } from "@/store/ReduxPersistenceContext";
-import type { StarterBrickType } from "@/types/starterBrickTypes";
+import {
+  type StarterBrickType,
+  StarterBrickTypes,
+} from "@/types/starterBrickTypes";
 import type { EditorState } from "@/pageEditor/pageEditorTypes";
 import DimensionGate from "@/pageEditor/components/DimensionGate";
 import { allFramesInInspectedTab } from "@/pageEditor/context/connection";
 import DatabaseUnresponsiveBanner from "@/components/DatabaseUnresponsiveBanner";
 
 const STARTER_BRICKS_TO_EXCLUDE_FROM_CLEANUP: StarterBrickType[] = [
-  "actionPanel",
-  "panel",
+  StarterBrickTypes.SIDEBAR_PANEL,
 ];
 
 // When selecting a starter brick in the Page Editor, remove any existing starter bricks

src/pageEditor/panes/EditorPane.test.tsx

@@ -198,6 +198,11 @@ async function addABlock(addButton: Element, blockName: string) {
 }
 
 describe("renders", () => {
+  beforeEach(() => {
+    // :barf: these Jest snapshot contains sequence UUIDs
+    formStateFactory.resetSequence();
+  });
+
   test("the first selected node", async () => {
     const formState = getPlainFormState();
     const { instanceId } = formState.extension.blockPipeline[0];