#8607 Replace remaining occurrences of mod component form state "elements" #8712
Conversation
EditorPane
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8712 +/- ##
==========================================
- Coverage 73.69% 73.66% -0.04%
==========================================
Files 1344 1346 +2
Lines 41566 41655 +89
Branches 7775 7805 +30
==========================================
+ Hits 30633 30684 +51
- Misses 10933 10971 +38 ☔ View full report in Codecov by Sentry. |
Playwright test results
Details
Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
| @@ -155,22 +156,22 @@ const CreateModModalBody: React.FC = () => { | |||
| }, [dispatch]); | |||
|
|
|||
| const initialModMetadataFormState = useInitialFormState({ | |||
| activeElement: activeModComponent, | |||
| activeModComponentFormState: activeModComponent, | |||
There was a problem hiding this comment.
Rename the local variable produced by useSelector(selectActiveModComponentFormState);
| @@ -56,7 +56,9 @@ const MoveFromModModal: React.FC = () => { | |||
| const { isRemoveFromModModalVisible: show } = useSelector( | |||
| selectEditorModalVisibilities, | |||
| ); | |||
| const activeElement = useSelector(selectActiveModComponentFormState); | |||
| const activeModComponentFormState = useSelector( | |||
There was a problem hiding this comment.
NIT: I don't think the "active" prefix is necessary here. It just makes the code wordier
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
|
LGTM: see comment on one inaccurate name |
| ): DraftModComponent { | ||
| const elementConfig = ADAPTERS.get(formState.type); | ||
| const adapter = ADAPTERS.get(modComponentFormState.type); |
What does this PR do?