-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8609 Rename nodePreviewElement -> builderPreviewElement #8718
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8718 +/- ##
==========================================
+ Coverage 73.69% 73.71% +0.01%
==========================================
Files 1344 1349 +5
Lines 41566 41735 +169
Branches 7775 7819 +44
==========================================
+ Hits 30633 30764 +131
- Misses 10933 10971 +38 ☔ View full report in Codecov by Sentry. |
Realized that I accidentally made this branch off #8712, review that PR first so this diff can be fixed |
Playwright test resultsDetails Open report ↗︎ Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
Adding "do not merge" while awaiting base branch review to prevent the diff on that PR from blowing up |
3b6d29c
to
6833242
Compare
@grahamlangford @mnholtz can we merge this to avoid potential merge conflicts down the road? |
What does this PR do?
activeDocumentOrFormPreviewElement
->activeBuilderPreviewElement