Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8609 Rename nodePreviewElement -> builderPreviewElement #8718

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Jun 27, 2024

What does this PR do?

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.71%. Comparing base (c32e86f) to head (6833242).
Report is 61 commits behind head on main.

Files Patch % Lines
...tabs/editTab/editorNodeLayout/usePipelineNodes.tsx 62.50% 3 Missing ⚠️
...or/documentBuilder/hooks/useSelectParentElement.ts 0.00% 1 Missing ⚠️
...or/tabs/editTab/editorNodes/PipelineHeaderNode.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8718      +/-   ##
==========================================
+ Coverage   73.69%   73.71%   +0.01%     
==========================================
  Files        1344     1349       +5     
  Lines       41566    41735     +169     
  Branches     7775     7819      +44     
==========================================
+ Hits        30633    30764     +131     
- Misses      10933    10971      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnholtz
Copy link
Collaborator Author

mnholtz commented Jun 27, 2024

Realized that I accidentally made this branch off #8712, review that PR first so this diff can be fixed

@mnholtz mnholtz changed the base branch from main to feature/8607_slice_6 June 27, 2024 21:39
Copy link

github-actions bot commented Jun 27, 2024

Playwright test results

passed  80 passed
skipped  2 skipped

Details

report  Open report ↗︎
stats  82 tests across 29 suites
duration  11 minutes, 12 seconds
commit  6833242

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@twschiller twschiller added this to the 2.0.4 milestone Jun 27, 2024
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@mnholtz mnholtz added the do not merge Merging of this PR is blocked by another one label Jun 27, 2024
@mnholtz
Copy link
Collaborator Author

mnholtz commented Jun 27, 2024

Adding "do not merge" while awaiting base branch review to prevent the diff on that PR from blowing up

Base automatically changed from feature/8607_slice_6 to main June 28, 2024 11:58
@twschiller
Copy link
Contributor

twschiller commented Jun 28, 2024

Realized that I accidentally made this branch off #8712, review that PR first so this diff can be fixed

@mnholtz I merged that PR. Looks like you'll need to rebase this PR and fix any conflict that exist post-rebase

@mnholtz mnholtz force-pushed the feature/8609_document_preview_element_rename branch from 3b6d29c to 6833242 Compare June 28, 2024 17:19
@twschiller
Copy link
Contributor

@grahamlangford @mnholtz can we merge this to avoid potential merge conflicts down the road?

@mnholtz mnholtz removed the do not merge Merging of this PR is blocked by another one label Jun 28, 2024
@mnholtz mnholtz merged commit 359e47a into main Jun 28, 2024
18 checks passed
@mnholtz mnholtz deleted the feature/8609_document_preview_element_rename branch June 28, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Rename element -> documentPreviewComponent
2 participants