-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required env variables for e2e telemetry tests to README #8341
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8341 +/- ##
=======================================
Coverage 73.49% 73.50%
=======================================
Files 1330 1330
Lines 41142 41142
Branches 7657 7657
=======================================
+ Hits 30239 30242 +3
+ Misses 10903 10900 -3 ☔ View full report in Codecov by Sentry. |
Is it worth at all considering just removing the DEBUG check in pixiebrix-extension/src/telemetry/dnt.ts Line 34 in eb39806
We wouldn't emit metrics anyways if people don't set up their local datadog client token in the env. |
I suppose so? I don't see any reason to keep it, but I'm hesitant because I don't know why it's there. |
Here's the relevant change: I guess it's to prevent error telemetry in the production pixiebrix app server being polluted by local dev errors, though I'd argue that we should be distinguishing dev errors some other way but still recording them by default. In the interest of not blowing up the scope of this change, I guess we can leave in this check for now (maybe adding a comment in the relevant line in |
It already sort of is with the |
}; | ||
|
||
export const test = mergeTests( | ||
envSetup, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is unchanged except for wrapping this extend in mergeTests
and adding the additionalRequiredEnvVariables
override below.
// A call to `use` is required to continue the test, but the resolved value isn't used for anything in our case. | ||
// Typescript requires that we have it match the type of expectRequiredEnvVariables. | ||
await use(() => {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can avoid this by defining the value as void for the fixture
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
…/pixiebrix/pixiebrix-extension into feature/update_playwright_readme merge main
What does this PR do?
Checklist