-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run e2e tests for beta-release unless skipped #8350
Conversation
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8350 +/- ##
=======================================
Coverage 73.50% 73.51%
=======================================
Files 1330 1330
Lines 41142 41142
Branches 7657 7657
=======================================
+ Hits 30241 30245 +4
+ Misses 10901 10897 -4 ☔ View full report in Codecov by Sentry. |
I made some changes to env variables recently that this branch will probably need to pull in. Merging with main to look into fixing that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, maybe I'm misunderstanding something. But I don't see E2E_TEST_USER_EMAIL_UNAFFILIATED
or E2E_TEST_USER_PASSWORD_UNAFFILIATED
.
Also, I want to make sure that we update the required env variables per changes made in #8341
In particular, I think we'll need to add DEV_EVENT_TELEMETRY
and DATADOG_CLIENT_TOKEN
@grahamlangford see @mnholtz's change request comments |
Done. |
What does this PR do?
Reviewer Tips
Checklist