Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run e2e tests for beta-release unless skipped #8350

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

grahamlangford
Copy link
Collaborator

What does this PR do?

Reviewer Tips

  • Changes in ci.yaml and release.yaml were just cleanup

Checklist

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.51%. Comparing base (6608569) to head (0a7cea5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8350   +/-   ##
=======================================
  Coverage   73.50%   73.51%           
=======================================
  Files        1330     1330           
  Lines       41142    41142           
  Branches     7657     7657           
=======================================
+ Hits        30241    30245    +4     
+ Misses      10901    10897    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnholtz
Copy link
Collaborator

mnholtz commented Apr 26, 2024

I made some changes to env variables recently that this branch will probably need to pull in. Merging with main to look into fixing that

Copy link
Collaborator

@mnholtz mnholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, maybe I'm misunderstanding something. But I don't see E2E_TEST_USER_EMAIL_UNAFFILIATED or E2E_TEST_USER_PASSWORD_UNAFFILIATED.

Also, I want to make sure that we update the required env variables per changes made in #8341

In particular, I think we'll need to add DEV_EVENT_TELEMETRY and DATADOG_CLIENT_TOKEN

@twschiller
Copy link
Contributor

@grahamlangford see @mnholtz's change request comments

@grahamlangford
Copy link
Collaborator Author

Sorry, maybe I'm misunderstanding something. But I don't see E2E_TEST_USER_EMAIL_UNAFFILIATED or E2E_TEST_USER_PASSWORD_UNAFFILIATED.

Also, I want to make sure that we update the required env variables per changes made in #8341

In particular, I think we'll need to add DEV_EVENT_TELEMETRY and DATADOG_CLIENT_TOKEN

Done. DATADOG_CLIENT_TOKEN was already included

@grahamlangford grahamlangford merged commit 20c8ee5 into main Apr 30, 2024
22 checks passed
@grahamlangford grahamlangford deleted the run-e2e-tests-beta-publish branch April 30, 2024 14:28
@grahamlangford grahamlangford modified the milestones: 1.8.13, 1.8.14 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants