-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: For Ruby 3.3 compatibility, specify racc dependency in gemspec #1013
Conversation
@faisal Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
@faisal This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary. |
I think this should actually be fixed in tomlrb: fbernier/tomlrb#50 |
We expect to be able to revert this change once the upstream issue is resolved. See pivotal/LicenseFinder#1013 and fbernier/tomlrb#50.
We expect to be able to revert this change once the upstream issue is resolved. See pivotal/LicenseFinder#1013 and fbernier/tomlrb#50.
@benlangfeld I'm confused by the tomlrb PR was merged without any fixes about the dependencies. |
In the hopes that it exposes pivotal#1013
The test suite passes on ruby 3.3. |
@faisal Ill add 3.3.x support to the pipeline. There are a few things missing from this so Ill make sure pipelines are added and they pass |
@xtreme-shane-lattanzio Thanks for maintenance, would you release a new version for Ruby 3.3 support? |
This PR adds racc to the gemspec, because Ruby 3.3 changes mean that without it we get:
@pivotal-cla This is an Obvious Fix