Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: For Ruby 3.3 compatibility, specify racc dependency in gemspec #1013

Closed
wants to merge 1 commit into from

Conversation

faisal
Copy link

@faisal faisal commented Jan 4, 2024

This PR adds racc to the gemspec, because Ruby 3.3 changes mean that without it we get:

~/test (+main) $ cat Gemfile 
# frozen_string_literal: true

source "https://rubygems.org"
~/test (+main) $ license_finder
<internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require': cannot load such file -- racc/parser.rb (LoadError)
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/tomlrb-2.0.3/lib/tomlrb/generated_parser.rb:7:in `<top (required)>'
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/tomlrb-2.0.3/lib/tomlrb/parser.rb:1:in `<top (required)>'
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/tomlrb-2.0.3/lib/tomlrb.rb:9:in `<top (required)>'
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/license_finder-7.1.0/lib/license_finder/package_managers/dep.rb:3:in `<top (required)>'
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/license_finder-7.1.0/lib/license_finder/package_manager.rb:175:in `<top (required)>'
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/license_finder-7.1.0/lib/license_finder/core.rb:9:in `<top (required)>'
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/license_finder-7.1.0/lib/license_finder.rb:13:in `<top (required)>'
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from <internal:/opt/homebrew/Cellar/ruby/3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
	from /opt/homebrew/lib/ruby/gems/3.3.0/gems/license_finder-7.1.0/bin/license_finder:4:in `<top (required)>'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bin/license_finder:25:in `load'
	from /opt/homebrew/lib/ruby/gems/3.3.0/bin/license_finder:25:in `<main>'
~/test (+main) $ 

@pivotal-cla This is an Obvious Fix

@pivotal-cla
Copy link

@faisal Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@pivotal-cla
Copy link

@faisal This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@benlangfeld
Copy link
Contributor

I think this should actually be fixed in tomlrb: fbernier/tomlrb#50

benlangfeld added a commit to powerhome/oss-guide that referenced this pull request Jan 9, 2024
We expect to be able to revert this change once the upstream issue is resolved.

See pivotal/LicenseFinder#1013 and fbernier/tomlrb#50.
benlangfeld added a commit to powerhome/oss-guide that referenced this pull request Jan 9, 2024
We expect to be able to revert this change once the upstream issue is resolved.

See pivotal/LicenseFinder#1013 and fbernier/tomlrb#50.
@itchyny
Copy link

itchyny commented Jan 11, 2024

@benlangfeld I'm confused by the tomlrb PR was merged without any fixes about the dependencies.

benlangfeld added a commit to benlangfeld/LicenseFinder that referenced this pull request Jan 11, 2024
In the hopes that it exposes pivotal#1013
@benlangfeld benlangfeld mentioned this pull request Jan 11, 2024
@benlangfeld
Copy link
Contributor

@benlangfeld I'm confused by the tomlrb PR was merged without any fixes about the dependencies.

The test suite passes on ruby 3.3.

@xtreme-shane-lattanzio
Copy link
Contributor

@faisal Ill add 3.3.x support to the pipeline. There are a few things missing from this so Ill make sure pipelines are added and they pass

@itchyny
Copy link

itchyny commented Feb 1, 2024

@xtreme-shane-lattanzio Thanks for maintenance, would you release a new version for Ruby 3.3 support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants