Test on Ruby 3.3.0 #1014
Closed
Test on Ruby 3.3.0 #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the hopes that it exposes pivotal#1013
|
@benlangfeld Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
|
@benlangfeld Thank you for signing the Contributor License Agreement! |
benlangfeld
added a commit
to benlangfeld/LicenseFinder
that referenced
this pull request
Jan 12, 2024
On Ruby 3.3 the following warning is emitted: ``` /usr/local/bundle/ruby/3.3.0/gems/license_finder-7.1.0/lib/license_finder/package_managers/sbt.rb:3: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of license_finder-7.1.0 to add csv into its gemspec. ``` As of Ruby 3.4 license_finder would cease to work without this explicit dependency. See also pivotal#1014
|
@benlangfeld Ill add 3.3.x support to the pipeline. There are a few things missing from this so Ill make sure pipelines are added and they pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the hopes that it exposes #1013