Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test if connect() throw an unhandled exception #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Test if connect() throw an unhandled exception #13

wants to merge 2 commits into from

Commits on Mar 23, 2021

  1. Test if connect() throw an unhandled exception 

    I just find an issue with connect. When called on certain server the connection failed.
It throw correctly the error but an unhandle promise is also rejected. it should not be cough by the system and should be normally trapped.
I didn't investigate much more at the moment as I spend more time to reproduce the issue and create a test case.
I will come back with more detail to understand why connecting on that server trigger the `unhandledRejection` event.
    @peernohell
    peernohell authored Mar 23, 2021
    Configuration menu
    Copy the full SHA
    0bc532b View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2021

  1. fix unhandled exception on failed updateCapability 

    When `updateCapability` failed, the reject is not call and an unhandled exception is throw
    @peernohell
    peernohell authored Mar 27, 2021
    Configuration menu
    Copy the full SHA
    c2ba780 View commit details
    Browse the repository at this point in the history