Test if connect() throw an unhandled exception #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just find an issue with connect. When called on certain server the connection failed. It throw correctly the error but an unhandle promise is also rejected. it should not be cough by the system and should be normally trapped. I didn't investigate much more at the moment as I spend more time to reproduce the issue and create a test case. I will come back with more detail to understand why connecting on that server trigger the `unhandledRejection` event.
|
If found what's happened. the fix is pretty easy. We just need to replace the line this.updateCapability()
.then(() => resolve(this._capability))by this.updateCapability()
.then(() => resolve(this._capability), reject)Then the issue stop to produce. |
When `updateCapability` failed, the reject is not call and an unhandled exception is throw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just find an issue with connect. When called on certain server the connection failed.
It throw correctly the error but an unhandle promise is also rejected. it should not be cough by the system and should be normally trapped.
I didn't investigate much more at the moment as I spend more time to reproduce the issue and create a test case.
I will come back with more detail to understand why connecting on that server trigger the
unhandledRejectionevent.If you have any suggestion on modification or code to adjust please don't hesitate 🙏