sctp.Client guarantees its own streams map has OpenStreams #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
once association.readLoop goroutine runs, It can be exited by any reason. When readLoop is done, defer calls unregisterStream which send signal Stream's sync.Cond var. If readLoop is done before association.OpenStream is called, Stream.ReadSCTP's sync.Cond wait for signal infinitely because association.streams doesn't have any stream yet.
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
- Coverage 80.69% 80.58% -0.12%
==========================================
Files 47 47
Lines 3901 3904 +3
==========================================
- Hits 3148 3146 -2
- Misses 616 619 +3
- Partials 137 139 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Unfortunately, It happens again after applying this to our system. I think this is not a solution for leak. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
once association.readLoop goroutine runs, It can be exited by
any reason. When readLoop is done, defer calls
unregisterStream which send signal Stream's sync.Cond var.
If readLoop is done before association.OpenStream is called,
Stream.ReadSCTP's sync.Cond wait for signal infinitely
because association.streams doesn't have any stream yet.
this is for pion/webrtc#2098
Reference issue
Fixes #...