Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass streamIdentifiers when running sctp.Client #2162

Closed
wants to merge 1 commit into from

Conversation

lenaky
Copy link
Contributor

@lenaky lenaky commented Mar 31, 2022

Description

To prevent leaking dataChannel.readLoop,
Send streamIdentifiers to sctp.Client

It's related pion/sctp PR.
See also pion/sctp#219

Reference issue

Fixes #2098

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #2162 (151ffae) into master (260e7ef) will decrease coverage by 7.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2162      +/-   ##
==========================================
- Coverage   76.88%   69.48%   -7.41%     
==========================================
  Files          87       64      -23     
  Lines        8946     3267    -5679     
==========================================
- Hits         6878     2270    -4608     
+ Misses       1649      873     -776     
+ Partials      419      124     -295     
Flag Coverage Δ
go ?
wasm 69.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
constants.go 0.00% <0.00%> (-100.00%) ⬇️
icecandidatepair.go 0.00% <0.00%> (-81.82%) ⬇️
rtpcodec.go 13.33% <0.00%> (-80.00%) ⬇️
stats.go 0.00% <0.00%> (-75.00%) ⬇️
track_local.go 0.00% <0.00%> (-66.67%) ⬇️
internal/mux/muxfunc.go 9.09% <0.00%> (-63.64%) ⬇️
icemux.go 0.00% <0.00%> (-54.55%) ⬇️
atomicbool.go 57.14% <0.00%> (-42.86%) ⬇️
sdpsemantics.go 0.00% <0.00%> (-34.49%) ⬇️
internal/mux/endpoint.go 24.13% <0.00%> (-34.49%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260e7ef...151ffae. Read the comment docs.

To prevent leaking Stream.readLoop,
Send streamIdentifiers to sctp.Client
@lenaky
Copy link
Contributor Author

lenaky commented Apr 29, 2022

Unfortunately, It happens again after applying this to our system. I think this is not a solution for leak.

@lenaky lenaky closed this Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

DataChannel.readLoop goroutine leak
1 participant