Add H.265 payloader fork #165 #287
Conversation
This change completes the H265 implementation.
|
@kevmo314 @Sean-Der @lebedyncrs Can you please confirm that you have made the corrections associated with the test? |
| return | ||
| } | ||
|
|
||
| if len(nalu) <= int(mtu) { | ||
| naluLen := len(nalu) + 2 |
There was a problem hiding this comment.
To prevent the MTU size from being exceeded during aggregation packet, the size is compared by adding 2 bytes for the aggregation header.
|
|
||
| if aggregationBufferSize+marginalAggregationSize > int(mtu) { | ||
| flushBufferedNals() | ||
| marginalAggregationSize = calcMarginalAggregationSize(nalu) |
There was a problem hiding this comment.
After flushing, recalculate because the margin conditions change.
y-kawawa
changed the title
|
Base branch changed to master. |
|
@kevmo314 @Sean-Der @lebedyncrs Changed to a form of forking PR. |
|
Thanks for adding the tests here. This change looks good to me. I know @Sean-Der had some thoughts on the tests so I'll let him approve but if he isn't able to get to this PR in a few days I'll also approve it so we can get it unblocked. @lebedyncrs contributions to https://opencollective.com/pion are super appreciated :) |
|
Hello! We’re working on updating the linters[1], Sorry I caused a conflict on your branch, Would you like me to fix it and fix the lint issues on your branch? Thank you so much for your work! <3 |
|
@joeturki |
Approved the workflow run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
==========================================
+ Coverage 83.70% 84.69% +0.98%
==========================================
Files 24 24
Lines 2535 2699 +164
==========================================
+ Hits 2122 2286 +164
Misses 354 354
Partials 59 59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
y-kawawa
force-pushed
the
master
branch
3 times, most recently
from
8b9ba4e to
e4d4bf1
Compare
y-kawawa
force-pushed
the
master
branch
2 times, most recently
from
cce2e93 to
4549554
Compare
|
@kevmo314
|
|
@y-kawawa I approved it again, don't worry. as soon as I get a notification, I'll approve it :) |
|
@joeturki Thanks 🙏 |
DONL is increased by 2 the first time and 1 thereafter.
H265Packet is no longer comparable due to the inclusion of nalBuffer, etc. of slices in H265Packet. Once reversed because it falls under the check for fixing incompatibilities.
|
I misunderstood Linter's point. (Fixed) |
|
Btw you can install and run Thanks :) |
|
Thanks again and again . |
|
This PR looks good. Thank you for the work adding the tests! I haven't heard from Sean on any other requests so I'll go ahead and approve so we can get this in. |
Description
Add H265Payloader
fork from #165
H265Payloader function
diff from #165
Operation check
Chrome
Safari