-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add h265 payloader #286
add h265 payloader #286
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #286 +/- ##
==========================================
+ Coverage 83.71% 83.96% +0.25%
==========================================
Files 24 24
Lines 2450 2514 +64
==========================================
+ Hits 2051 2111 +60
- Misses 340 343 +3
- Partials 59 60 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This looks perfect! I will fix linter and merge tonight :) excited to use ir |
Thanks for the PR. It would be helpful to have a payloader implementation for H.265. However, I prefer #165 because it has a |
Thanks for the comment. I actually missed #165, when started working on my payloader. However it looks pretty stalled on the test adding stage. And this one already has tests and is confirmed to work in browser (see attach).
So, I guess its up to @Sean-Der to decide :) |
@z1rachl I have confirmed that it works on chrome . So functionality and whether #165 still has the motivation to move forward with PR will be the determining factor. |
Hello! We’re working on updating the linters[1], Sorry I caused conflicts on your branch, Would you like me to fix the conflicts and fix the lint issues on your branch? Thank you so much for your work! <3 |
Closed in favor of #287 |
Description
Add h265 payloader support, that allows to split large h265 packets to FUs not bigger than requested mtu. It is mostly based on h264 payloader with rtp headers generation changes according to RFC 7798