Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move buffer for RTP packets into internal #280

Merged
merged 1 commit into from
Oct 14, 2024

Move buffer for RTP packets into internal

fa94c8c
Select commit
Loading
Failed to load commit list.
Merged

Move buffer for RTP packets into internal #280

Move buffer for RTP packets into internal
fa94c8c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 14, 2024 in 1s

72.76% (-0.22%) compared to 0eab188

View this Pull Request on Codecov

72.76% (-0.22%) compared to 0eab188

Details

Codecov Report

Attention: Patch coverage is 84.94624% with 14 lines in your changes missing coverage. Please review.

Project coverage is 72.76%. Comparing base (0eab188) to head (fa94c8c).

Files with missing lines Patch % Lines
internal/rtpbuffer/rtpbuffer.go 82.00% 4 Missing and 5 partials ⚠️
internal/rtpbuffer/retainable_packet.go 90.00% 1 Missing and 1 partial ⚠️
pkg/nack/receive_log.go 33.33% 0 Missing and 2 partials ⚠️
internal/rtpbuffer/packet_factory.go 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   72.98%   72.76%   -0.22%     
==========================================
  Files          79       80       +1     
  Lines        3679     3679              
==========================================
- Hits         2685     2677       -8     
- Misses        863      867       +4     
- Partials      131      135       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov