Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move buffer for RTP packets into internal #280

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

Sean-Der
Copy link
Member

Can be used by NACK and JitterBuffer now

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 84.94624% with 14 lines in your changes missing coverage. Please review.

Project coverage is 72.76%. Comparing base (0eab188) to head (fa94c8c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/rtpbuffer/rtpbuffer.go 82.00% 4 Missing and 5 partials ⚠️
internal/rtpbuffer/retainable_packet.go 90.00% 1 Missing and 1 partial ⚠️
pkg/nack/receive_log.go 33.33% 0 Missing and 2 partials ⚠️
internal/rtpbuffer/packet_factory.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   72.98%   72.76%   -0.22%     
==========================================
  Files          79       80       +1     
  Lines        3679     3679              
==========================================
- Hits         2685     2677       -8     
- Misses        863      867       +4     
- Partials      131      135       +4     
Flag Coverage Δ
go 72.76% <84.94%> (-0.11%) ⬇️
wasm 70.37% <80.64%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der force-pushed the simplify-jitter-buffer branch from 9d79804 to aedeaae Compare October 14, 2024 02:34
Can be used by NACK and JitterBuffer now

Relates to #278
@Sean-Der Sean-Der force-pushed the simplify-jitter-buffer branch from aedeaae to fa94c8c Compare October 14, 2024 02:36
@Sean-Der Sean-Der merged commit d34a3c5 into master Oct 14, 2024
15 checks passed
@Sean-Der Sean-Der deleted the simplify-jitter-buffer branch October 14, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant