Added casting to string of slurm_stderr and jobinfo_stdout #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility with Python 3, where subprocess is returning bytes instead of string. This fix was discussed on this issue. I have tested this on a Slurm cluster with both a Python 3.6 environment and a Python 2.7 environment, so the casting with
str
seems to work. There is a possibility to specify the encoding, using.decode('utf-8')
or similar. I don't know when/if this would be necessary.