Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added casting to string of slurm_stderr and jobinfo_stdout #48

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

pietromarchesi
Copy link
Contributor

For compatibility with Python 3, where subprocess is returning bytes instead of string. This fix was discussed on this issue. I have tested this on a Slurm cluster with both a Python 3.6 environment and a Python 2.7 environment, so the casting with str seems to work. There is a possibility to specify the encoding, using .decode('utf-8') or similar. I don't know when/if this would be necessary.

For compatibility with Python 3, where subprocess is returning bytes instead of string
@samuell
Copy link
Member

samuell commented Feb 2, 2018

Cool, thanks @pietromarchesi ! This looks to be a clear improvement over the current situation, so merging.

I realize its due time to set up continuous integration, to be safer about merging things in the future. Hope to look at that in the coming week or weeks (a bit entrenched in deep a scipipe refactoring right now ;) ... so after that).

@samuell samuell merged commit a98161d into pharmbio:master Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants