Fixes for ROS Kinetic #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added SYSTEM flag for dependencies.
psigen
approved these changes
Apr 30, 2017
There was a problem hiding this comment.
Seems fine to me given the current code is not using this function.
I honestly have no idea what we added the make_relative() function for, but I remember it having some purpose. It might have been intended to address resolution of referenced assets in URDFs in some sort of situation where we needed OpenRAVE to use a URDF that had a strange internal path. But I have no idea what that situation would be now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains @ClintLiddick's changes that make
or_urdfcompatible with ROS kinetic. It does not seem to break backwards compatibility with ROS indigo.