Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe this pull request. Link to relevant GitHub issues, if any.
Paired with
ada_feeding
#128, this PR splits MoveToMouth into two actions, with face detection in-between handled by the web app and transparently exposed to the user.Explain how this pull request was tested, including but not limited to the below checkmarks.
Then, test the following.
feedingwebapp
README to launch the dummy nodes along with the web app.Back
should callMoveFromMouthToStagingConfiguration
(Move To Mouth: getting stuck in error cases #90 ).Retry
button does not appear after the app registers the failure. (Don't show "Retry" if Bite Acquisiton Fails #91).ada_feeding
README to launch the real robot nodes along with the web app.Back
should callMoveFromMouthToStagingConfiguration
(Move To Mouth: getting stuck in error cases #90 ).Retry
button does not appear after the app registers the failure. (Don't show "Retry" if Bite Acquisiton Fails #91).Before creating a pull request
npm run format
python3 -m black .
in the top-level of this repositoryBefore merging a pull request
Squash and Merge
)