Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split MoveToMouth Into two Actions #94

Merged
merged 9 commits into from
Nov 15, 2023
Merged

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented Nov 13, 2023

Describe this pull request. Link to relevant GitHub issues, if any.

Paired with ada_feeding#128, this PR splits MoveToMouth into two actions, with face detection in-between handled by the web app and transparently exposed to the user.

Explain how this pull request was tested, including but not limited to the below checkmarks.

Then, test the following.

  • Sim:
    • Follow the instructions in the feedingwebapp README to launch the dummy nodes along with the web app.
    • Test one whole bite normally, ensure it works. (Note that the bite selection image will not display, since we aren't running the republisher)
    • Pause it while it is moving to the staging configuration, ensure back and resume do the correct things.
    • Pause it while it is moving to the user's mouth, ensure back and resume do the correct things. In particular, Back should call MoveFromMouthToStagingConfiguration (Move To Mouth: getting stuck in error cases #90 ).
    • Make bite acquisition fail (e.g., terminating the node) and verify that the Retry button does not appear after the app registers the failure. (Don't show "Retry" if Bite Acquisiton Fails #91).
    • Verify that it doesn't auto-continue when that box is not checked, it does when that box is checked, and the state of that checkbox persists.
  • Real:
    • Follow the instructions in the ada_feeding README to launch the real robot nodes along with the web app.
    • Test one whole bite normally, ensure it works.
    • Pause it while it is moving to the staging configuration, ensure back and resume do the correct things.
    • During face detection, ensure there is no face in the scene. Verify that it doesn't progress.
    • During face detection, put a face more than 1.25m away from the camera. Verify that it doesn't proceed.
    • Press to continue moving to the mouth without detecting a face. Verify that the arm moves to the old face position.
    • Pause it while it is moving to the user's mouth, ensure back and resume do the correct things. In particular, Back should call MoveFromMouthToStagingConfiguration (Move To Mouth: getting stuck in error cases #90 ).
    • Make bite acquisition fail (e.g., terminating the node) and verify that the Retry button does not appear after the app registers the failure. (Don't show "Retry" if Bite Acquisiton Fails #91).
    • Verify that it doesn't auto-continue when that box is not checked, it does when that box is checked, and the state of that checkbox persists.

Before creating a pull request

  • Format React code with npm run format
  • Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • [N/A] Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • [N/A] Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@amalnanavati amalnanavati linked an issue Nov 13, 2023 that may be closed by this pull request
@amalnanavati amalnanavati merged commit c774e43 into main Nov 15, 2023
4 checks passed
@amalnanavati amalnanavati deleted the amaln/move_to_mouth_split branch November 15, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant