Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make payjoin-cli msrv 1.63.0 #119

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Make payjoin-cli msrv 1.63.0 #119

merged 5 commits into from
Nov 29, 2023

Conversation

DanGould
Copy link
Contributor

@DanGould DanGould commented Nov 27, 2023

  • Swap blocking rouille for async hyper, since rouille depends on hyper anyhow.
  • Lower clap version to support msrv
  • Use ureq insetad of reqwest to support msrv (and reduce binary size as a side effect)
  • Combine now shared msrv build between tests
  • Share a workspace, allowing better editor & build support now that we're on the same msrv

@DanGould
Copy link
Contributor Author

msrv +1.63 requires at a minnimum

cargo +1.63.0 update -p time --precise 0.3.20
cargo update -p regex --precise 1.9.6

And reqwest will have to be swapped out

@DanGould DanGould changed the title Swap rouille for hyper Make payjoin-cli msrv 1.63.0 Nov 28, 2023
@DanGould DanGould marked this pull request as ready for review November 28, 2023 18:47
@DanGould DanGould force-pushed the hyper branch 3 times, most recently from 8e9c801 to f999b19 Compare November 29, 2023 01:10
@DanGould DanGould requested a review from jbesraa November 29, 2023 03:15
@DanGould DanGould force-pushed the hyper branch 6 times, most recently from bd4370d to 609c0f5 Compare November 29, 2023 18:02
@DanGould DanGould mentioned this pull request Nov 29, 2023
@DanGould DanGould merged commit c8baf67 into payjoin:master Nov 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant