Skip to content

Commit

Permalink
Test payjoin-cli 1.63.0 msrv
Browse files Browse the repository at this point in the history
  • Loading branch information
DanGould committed Nov 29, 2023
1 parent d439d9e commit f999b19
Show file tree
Hide file tree
Showing 3 changed files with 46 additions and 122 deletions.
17 changes: 8 additions & 9 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,6 @@ jobs:
if: matrix.rust == '1.63.0'
run: |
cargo update
cargo update -p log --precise 0.4.18
cargo update -p tempfile --precise 3.6.0
cargo update -p flate2 --precise 1.0.26
cargo update -p minreq --precise 2.8.0
cargo update -p rustls --precise 0.20.8
cargo update -p webpki --precise 0.22.2
cargo update -p byteorder --precise 1.4.3
cargo update -p regex --precise 1.9.6
- name: test
run: cargo test --verbose --all-features --lib
Expand All @@ -47,7 +40,7 @@ jobs:
strategy:
fail-fast: false
matrix:
rust: [stable, nightly]
rust: [1.63.0, stable, nightly]

steps:
- uses: actions/checkout@v2
Expand All @@ -56,9 +49,15 @@ jobs:
with:
toolchain: ${{ matrix.rust }}
override: true
- name: Fixes for MSRV
if: matrix.rust == '1.63.0'
run: |
cargo update
cargo update -p regex --precise 1.9.6
cargo update -p [email protected] --precise 0.3.20
- name: build payjoin cli example
run: |
cargo test --verbose --features=local-https
cargo test --verbose --features=danger-local-https
fmt:
runs-on: ubuntu-latest
Expand Down
18 changes: 9 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,22 +72,22 @@ Seeking review of the code that verifies there is no overpayment. Contributions

## Minimum Supported Rust Version (MSRV)

The `payjoin` library should always compile with any combination of features on Rust **1.63.0**.
The `payjoin` library and `payjoin-cli` should always compile with any combination of features on Rust **1.63.0**.

To build and test with the MSRV you will need to pin the below dependency versions:

### `payjoin`

```shell
cargo update -p log --precise 0.4.18
cargo update -p tempfile --precise 3.6.0
cargo update -p flate2 --precise 1.0.26
cargo update -p minreq --precise 2.8.0
cargo update -p rustls --precise 0.20.8
cargo update -p webpki --precise 0.22.2
cargo update -p byteorder --precise 1.4.3
cargo update -p regex --precise 1.9.6
```

The `payjoin-cli` should compile with Rust **stable** MSRV
### `payjoin-cli`

```shell
cargo update -p regex --precise 1.9.6
cargo update -p [email protected] --precise 0.3.20
```

## License

Expand Down
133 changes: 29 additions & 104 deletions payjoin-cli/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f999b19

Please sign in to comment.