-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.2.0 #787
Merged
Merged
Release v1.2.0 #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add pyproject.toml to all packages * Improve the publishing workflow
* Fix typo in docstring of draw * Fix mypy error
…__ now on __str__ (#770)
* Include the beam's propagation direction in Channel * Apply amplitude fluctuations from run to run instead of pulse to pulse * Correct emulation of finite-waist effects on amplitude * Fix handling or laser_waist to/from SimConfig * UTs for the noise * Include propagation_dir in the JSON schema * Fix error in conversion between SimConfig and NoiseModel * Add the pulser version to serialized devices * Missing UT for Channel * Adopting review suggestions
* Set draw_phase_curve to True by default * Fix phase curve * Always display phase in draw_phase_area
…se (#773) * Add estimate_add_delay * Fix test coverage * Add testing of DMM * Address review comments * Fix test
* Deprecate usage of int * Fix tutorials * Fix targets * Update warning message * Fix tutorials * Revert "Fix tutorials" This reverts commit a99d615. * Fix tutorial * Fix typing with qubitID=str * Fix tests * Fix typing * Fix tests * Fix built in values for register generation * Fix tests * Address review comments
* Setting up Markdown support * Convert Conventions page to markdown * Attempt to use auto-generated labels
* Add all missing specs * Add property specs * Move _specs to BaseDevice In this way, _specs and print_specs can also be called for virtual devices. * Fix syntax for compatibility with older Python * Fix style * Add missing docstring * Fix dosctring style * Improve specs method * Update to fix mypy errors * Fix mypy error * Add tests for BaseDevice.specs property * Fix import order * Various minor improvements One change is to use a string instead of joining elements of a list to get the final string. The reason is that lists were cumbersome to use when there were conditional statements. * Split _specs method in different methods Create one _specs method for each sections (register, layout, device, channels). The layout section is defined only in Device, such that it is not displayed for VirtualDevice. This commit also goes back to using lists for storing the lines. * Remove line * Fix typo in strings * Return list[str] instead of str for specs blocks Also move texts for layout to BaseDevice, since virtual devices can have some layouts properties. --------- Co-authored-by: Henrique Silvério <[email protected]>
…tion for phase (#779) * Adding Channel.custom_phase_jump_time * Restrict phase jump time for EOM mode * Eliminate modulation for phase * Unit tests * Improve docstring
* Qutip 4 compatible changes * Qutip 5 breaking changes * Fix test, handling of exception in NoiseModel * Convert all Qobj to CSR * Fix typing * Fix typing * Fix lint * Delete print * Address nit * Convert initial state to CSR --------- Co-authored-by: HGSilveri <[email protected]> Co-authored-by: Henrique Silvério <[email protected]>
* Define AbstractArray.is_differentiable * Remove warnings.simplefilter that was overriding pytest filterwarnings * Rename is_differentiable -> requires_grad
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
a-corni
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes: