Rejig block selection to properly respect --at
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-fix-execute-block-executing-wrong-block
execute_block.rs
offchain_worker.rs
11 tasks
liamaharon
changed the title
--at--at
pmikolajczyk41
approved these changes
Nov 9, 2023
ggwpez
approved these changes
Nov 9, 2023
…m-fix-execute-block-executing-wrong-block
This reverts commit 95ced09.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
execute-blockandoffchain-workercommands currently executes thenth + 1block extrinsics on top of the state of thenthblock.Instead, we should execute the
nthblock extrinsics on top of the state of thenth - 1block.This not only is a more clear API, but fixes an issue where the CLI tries to fetch state for a block that does not exist (encountered this here: https://github.com/paritytech/polkadot-sdk/actions/runs/6796531510/job/18476812057?pr=1938#step:7:98)
cc @ggwpez @Szegoo