-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Scheduled try-state
checks and alerting
#1938
Conversation
What is the purpose of running it every hour? |
To notify us asap in the case of any storage invariants breaking. |
Shouldn't this be some continuous job? |
I think follow-chain should check the storage invariants, or? |
Ideally, yes we would have dedicated infrastructure that runs In reality, there're some drawbacks of using
Internally,
For these reasons, I suggested to Kian and he agreed to opt to go with this approach for checking storage invariants. My backlog of work is pretty large, so this option is nice as it allows us to get something out the door quickly that works and doesn't (as far as we could tell) have significant drawbacks compared with dedicated infra running |
try-state
checks and alertingtry-state
checks and alerting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
- cron: "0 0 * * *" | ||
|
||
env: | ||
# TODO: Replace this with paritytech/polkadot-sdk 'latest' release URL once 1.3.0 is published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.3.0 did not include the Github workflow that builds the runtimes so we need to wait 1 more release for that to happen automatically, but I'm inclined to upload the debug builds there manually so we can use it.
Now that we're running full try-state checks in the CI I'm questioning how valuable this cron job will be. Looking into some alternatives that will hopefully provide more value and be more easily accessible to ecosystem chains without them needing to spin up dedicated CI infra. |
Schedule a Github Action every day to run
try-runtime
try-state
checks on all runtimes.This is a 0 -> 1 task to get our
try-state
checks deployed at all. In the future, it would be better for us to move these checks to dedicated infrastructure that can run them more frequently, perhaps usingfollow-chain
.Task list
try-state
passes on all runtimestry-state
invariants on Westend #2020try-state
developer experience & fix bug #2019See if we can optimise build times in the runnerwe'll have caching to resolve this soonvalue passed in; value comes out; qed
error from contracts rococo https://github.com/paritytech/polkadot-sdk/actions/runs/6796531510/job/18476812057?pr=1938#step:7:97)--at
try-runtime-cli#55