Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elastic scaling RFC 103 end-to-end tests #6452
base: master
Are you sure you want to change the base?
elastic scaling RFC 103 end-to-end tests #6452
Changes from 10 commits
4f898fc
89d8e97
a2028bf
0fcdcbb
c81783f
d7fba75
2e83300
3a6b09e
037a632
dd3ede2
478fbb7
6f4dbb4
610f29d
7e1f0d4
78eaf5e
184f206
01fbf6b
12c9f10
069b7ba
385a139
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my general comment is that using zombienet-v1 for measuring throughput via timeout will always be hacky and result in flaky tests:
then we're trying to measure parachain throughput via block height and timeouts - again this is flaky, because we are not starting to wait from 0 - the risk is having "passing tests", but broken functionality
we should switch to using zombienet-sdk tests IMHO, especially for newly written tests. are there any blockers for doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. I chose not to do this in the beginning because it would have taken a longer time and I was quite busy.
I switched to using zombienet-sdk test now, please have a look