-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elastic scaling RFC 103 end-to-end tests #6452
base: master
Are you sure you want to change the base?
Conversation
polkadot/zombienet_tests/elastic_scaling/0003-slot-based-3cores.toml
Outdated
Show resolved
Hide resolved
polkadot/zombienet_tests/elastic_scaling/0003-slot-based-3cores.toml
Outdated
Show resolved
Hide resolved
# Wait for 20 relay chain blocks | ||
elastic-validator-0: reports substrate_block_height{status="best"} is at least 20 within 140 seconds | ||
|
||
elastic-validator-0: parachain 2100 block height is at least 20 within 30 seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my general comment is that using zombienet-v1 for measuring throughput via timeout will always be hacky and result in flaky tests:
- we are waiting the substrate block height to be at least 20, but our intent is to wait for the next timeslice to kick in - this check might have false positives (block number > 20, but timeslice didn't kick in)
then we're trying to measure parachain throughput via block height and timeouts - again this is flaky, because we are not starting to wait from 0 - the risk is having "passing tests", but broken functionality
we should switch to using zombienet-sdk tests IMHO, especially for newly written tests. are there any blockers for doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. I chose not to do this in the beginning because it would have taken a longer time and I was quite busy.
I switched to using zombienet-sdk test now, please have a look
All GitHub workflows were cancelled due to failure one of the required jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the rewrite! looks like it will be less flaky and we can assert more things
.wait_for_finalized_success() | ||
.await?; | ||
|
||
log::info!("2 more cores assigned to the parachain"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are they assigned instantly after the block with assign_core
transaction was finalized? don't we need to wait for timeslice 1 here? i guess this is why we had to wait for 20 blocks before in the test
Adds two new zombienet-sdk tests:
Also enables the V2 receipts node feature for testnet genesis config.
Part of #5049