Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Based on work here, it seems like I got a fully functional version of libcapstone 5.0.4 working, I locally tested this, I can see libcapstone, I want to test this somehow.
capstone-engine/capstone#2569
PANDA Integration tests taint2, which uses callstack_instr, which uses capstone. So if this passes, the Debian Package works as expected.
Once the confirmation is complete, I'll ask capstone to create a 5.0.4 release, with the Debian package, and I'd need to tweak this PR to match the capstone GitHub address. Do NOT merge even if it passes! Ideally I'd want to grab the Debian package from capstone than my fork!!!!
Although, I think based on the work, it seems we should be very close to be able to put this on Debian apt repos directly too
P. S.
The Debian package already will run ldconfig for you. See Original #1558